| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Originally, the file dialog does not provide any filter.
Therefore, it is harder to find a file for an avatar, and
easier to select a non-image or an image with an
unsupported image format that would be not suitable here.
Hence, a format filter for any supported type as the
default makes it easier to make an expected input. Also,
adding each supported format individually helps users to
find an image in cases of directories with many image
files.
Signed-off-by: Markus Göllnitz <camelcasenick@bewares.it>
|
|
|
|
|
|
|
| |
The file chooser has been deprecated, but can be easily
replaced with Gtk.FileDialog.
Signed-off-by: Markus Göllnitz <camelcasenick@bewares.it>
|
|
|
|
|
|
|
|
|
|
|
|
| |
The AppStream data is automatically completed from a
referenced desktop file. The desktop file here, however,
is hardcoded to be org.gnome.Contacts. That leads to
Software displaying the org.gnome.Contacts icon, even
for the .Devel variant.
see: <https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Application.html>
Signed-off-by: Markus Göllnitz <camelcasenick@bewares.it>
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
The current `QueryFilter` code performs an invalid optimization on
search query updates by assuming a `FilterChange` of
MORE_STRICT/LESS_STRICT when it should be DIFFERENT:
- If the search string is extended, fewer contacts qualify for matching,
but some might start to pass the threshold.
- If the search string is shrunk, more contacts qualify for matching,
but some might no longer pass the threshold.
|
|
|
|
| |
This is the correct icon to use for secondary menus.
|
|
|
|
| |
Gets rid of the custom button in the menu.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Vala doesn't really do basic compiler checks on calls to
`g_return_*_if_fail()` in Vala code, leading to errors in clang. In
these cases, it should be fine to do a hard `assert` instead, since
those functions not working would probably lead to a segfault later on
anyway.
Fixes: https://gitlab.gnome.org/GNOME/gnome-contacts/-/issues/275
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
The Main Menu is also known as the primary menu, so it doesn't
make sense to set the secondary menu as primary.
(cherry picked from commit b3f2b50883198df47c7a2a0e98ecfb9ff3c775f0)
|
|
|
|
|
|
|
| |
These days meson complains a bit if you `meson $BUILDDIR` instead of
`meson setup $BUILDDIR`, so update our instructions. While we're at it,
adjust them to use the meson-specific wrappers for building and
installing, rather than using ninja directly
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a few more vCard tests to make sure we're not regressing on our
vCard import feature.
One of the design desicions at the time was to make the
`Contacts.Io.Parser` take a `GLib.InputStream` so we can make it
agnostic of what kind of input was given. We can now use this to make
the vCard tests a bit simpler in general by using a constant string
inside the test file rather than having to deal with environment
variables to pass on a path.
|
| |
|
|
|
|
|
| |
So when we import vCard files that have those properites, we don't
forget about them.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rather than building a big if-else block in the `Contacts.Io` namespace,
it's much more interesting to move the GVariant serialization into the
`Contacts.Chunk` objects themselves. That allows us to keep the
serialization logic for a specific field in one place and makes sure we
don't forget about any properties as they're not part of that big
if-else block that checks on property name.
This commit also make sure a lot of the functionality here is now unit
tested, to make sure we're not accidentally regressing.
|
| |
|
|
|
|
|
|
|
|
| |
We weren't sending out a property notification for `is-empty` when the
underlying `Folks.PostalAddress` changed, which meant that editing a
contact would only allows for a single address.
Also add a test to make sure we're not regressing on this.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|