summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* rpm: convert license to SPDX formatHEADmainDaniel P. Berrangé2023-05-071-1/+1
| | | | Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
* tests: uitests: make menu operations more robustCole Robinson2023-05-061-6/+11
| | | | Signed-off-by: Cole Robinson <crobinso@redhat.com>
* uitests: More attempts at making manager reposition test reliableCole Robinson2023-05-061-5/+9
| | | | Signed-off-by: Cole Robinson <crobinso@redhat.com>
* uitests: Make hotplug test pass on both f37 and f38Cole Robinson2023-05-061-4/+8
| | | | Signed-off-by: Cole Robinson <crobinso@redhat.com>
* tests: Default --uitests to --verbosity=2Cole Robinson2023-05-061-0/+4
| | | | Signed-off-by: Cole Robinson <crobinso@redhat.com>
* tests: uitests: Fix manager window repositioning testCole Robinson2023-05-051-4/+6
| | | | Signed-off-by: Cole Robinson <crobinso@redhat.com>
* tests: livetests: work around qemu media change regressionCole Robinson2023-05-051-0/+7
| | | | Signed-off-by: Cole Robinson <crobinso@redhat.com>
* tests: uitests: Fix window reposition on f38Cole Robinson2023-05-051-1/+1
| | | | Signed-off-by: Cole Robinson <crobinso@redhat.com>
* man/virt-install: Add a note about different behavior of --boot on s390xThomas Huth2023-03-221-0/+2
| | | | | | | | | | | | | | | | It is common on x86 and other architectures to install a guest from network by using "--boot hd,network" with virt-install - as long as the hard disk is not bootable yet, the installation will be started via network, and once it finished, the guest can boot from hd during the next reboot. However, this does not work on s390x since this architecture only supports one single boot device to be passed to the guest. Thus add a note to the documentation to avoid that people are running again into this common pitfall. Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2032472 Signed-off-by: Thomas Huth <thuth@redhat.com>
* tests: cli: test serial file cloneOleg Vasilev2023-03-223-0/+70
| | | | | | Previous commit added serial file clone, now we test it. Signed-off-by: Oleg Vasilev <oleg.vasilev@virtuozzo.com>
* cloner: clone serial filesOleg Vasilev2023-03-221-6/+24
| | | | | | | | | | Before this, on clone the serial file would remain the same for the cloned domain. This doesn't make much sense as the output would be an intermix of two unrelated output sequences. Here we apply the the same filename changing algorithm, as with disk files. Signed-off-by: Oleg Vasilev <oleg.vasilev@virtuozzo.com>
* virt-install: Document Secure Boot setupsAndrea Bolognani2023-02-091-2/+15
| | | | | | | | | | | | | | | Provide ready to use recipes for explicitly enabling and explicitly disabling Secure Boot, as well as a pointer to the more extensive information found on the libvirt website. Setting loader_secure=yes is only one part of a proper Secure Boot setup, so stop documenting it in the section about manual firmware selection to avoid confusion. https://bugzilla.redhat.com/show_bug.cgi?id=2112154 https://bugzilla.redhat.com/show_bug.cgi?id=2149971 Signed-off-by: Andrea Bolognani <abologna@redhat.com>
* virt-install: Recommend '--boot uefi'Andrea Bolognani2023-02-091-2/+2
| | | | | | | | Firmware autoselection is the way to go in most cases, so recommend that instead of telling users that they should provide all information manually. Signed-off-by: Andrea Bolognani <abologna@redhat.com>
* Packit: initial enablementLokesh Mandvekar2023-01-191-0/+19
| | | | | | | | This commit enables Packit `copr_build` tasks which will run on every PR and build RPMS using the spec file present upstream with Source0 as the archive created from HEAD commit of the PR. Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
* asyncjob: Remove unused importCole Robinson2023-01-191-1/+0
| | | | Signed-off-by: Cole Robinson <crobinso@redhat.com>
* tests: test win11 XML generationCole Robinson2023-01-194-9/+189
| | | | | | | And drop the futureproofing workaround now that it's no longer required Signed-off-by: Cole Robinson <crobinso@redhat.com>
* asyncjob: Fix backtrace when no cursor theme installedCole Robinson2023-01-191-3/+1
| | | | | | Fixes: https://github.com/virt-manager/virt-manager/issues/479 Signed-off-by: Cole Robinson <crobinso@redhat.com>
* virtinstall: Hide total_size in the progress bar if it doesn't needToshiki Sonoda2022-12-143-2/+24
| | | | | | | | | | | | virt-install prints the total_size value to the progress bar even if it is meaningless. This value can be confusing to user, so for execute prosess that doesn't copy files (total_size = 0B), we hide the total_size value. For example, 'Creating domain...' doesn't need to print the total_size value. Signed-off-by: Toshiki Sonoda <sonoda.toshiki@fujitsu.com> Signed-off-by: Haruka Ohata <ohata.haruka@fujitsu.com>
* virtinstall: Fix the allocating disk size printed by the progress barToshiki Sonoda2022-12-141-0/+1
| | | | | | | | | | | | When a sparse file is created during a disk allocation, virt-install prints not the created disk size but a sparse file size. Therefore, we fix to print the created disk size during disk allocation instead of the size of the sparse file by updating the meter with the self.capacity. Signed-off-by: Toshiki Sonoda <sonoda.toshiki@fujitsu.com> Signed-off-by: Haruka Ohata <ohata.haruka@fujitsu.com>
* progress: Fix showing correct final totalCole Robinson2022-12-147-8/+10
| | | | | | | | | | | | | | | | | | | | | | | | Reproducer: Reproducer: ./virt-install --connect test:///default \ --location tests/data/fakemedia/fake-f26-netinst.iso Before: Starting install... Retrieving 'vmlinuz' | 0 B 00:00:00 ... Retrieving 'initrd.img' | 0 B 00:00:00 ... After: Starting install... Retrieving 'vmlinuz' | 9 B 00:00:00 ... Retrieving 'initrd.img' | 9 B 00:00:00 ... progress.end() currently only reports the total amount of bytes that were last written to the UI. It should report the total amount that's been passed to update(). Reported-by: Toshiki Sonoda <sonoda.toshiki@fujitsu.com> Signed-off-by: Cole Robinson <crobinso@redhat.com>
* tests: Update to latest kvm domcapsCole Robinson2022-12-142-74/+91
| | | | | | And add some test coverage exclusions, needed for previous patches Signed-off-by: Cole Robinson <crobinso@redhat.com>
* tests: Add domcaps coverage for usb-redir/spicevmc channel checksLin Ma2022-12-141-0/+2
| | | | Signed-off-by: Lin Ma <lma@suse.com>
* guest: Query availability of spicevmc channels in domcapsLin Ma2022-12-142-0/+15
| | | | Signed-off-by: Lin Ma <lma@suse.com>
* guest: Query availability of usb redirdevs in domcapsLin Ma2022-12-142-0/+15
| | | | Signed-off-by: Lin Ma <lma@suse.com>
* Clean up FileChooser usage a bitCole Robinson2022-12-1410-141/+117
| | | | | | | * Move browse_reason handling entirely into storagebrowser.py * Open code some of the browse_local logic at the few callers Signed-off-by: Cole Robinson <crobinso@redhat.com>
* addhardware: Fix backtrace when controller.index is NoneCole Robinson2022-12-131-1/+1
| | | | | | | | | | | | When creating a new VM, in the customize wizard we can't depend on index= value being set (virtinst doesn't do it for example). For example, this causes a backtrace when adding two virtio-scsi controllers via the Customize wizard, or adding an extra virtio-scsi controller to an aarch64 CDROM install. Reported-by: Charles Arnold <carnold@suse.com> Signed-off-by: Cole Robinson <crobinso@redhat.com>
* tests: cpio: set owner to 0:0Weijia Wang2022-12-131-1/+1
|
* Fix pylint/pycodestyle warnings with latest versionsCole Robinson2022-12-1311-27/+28
| | | | Signed-off-by: Cole Robinson <crobinso@redhat.com>
* diskbackend: Drop support for sheepdogLin Ma2022-11-075-47/+7
| | | | | | | The sheepdog project is no longer actively developed, Libvirt removed the support for sheepdog storage backend since v8.8.0, Let's drop it. Signed-off-by: Lin Ma <lma@suse.com>
* cli: support --boot loader.stateless=Cole Robinson2022-10-174-3/+6
| | | | Signed-off-by: Cole Robinson <crobinso@redhat.com>
* virt-install: Reuse cli.fail_conflictingCole Robinson2022-08-222-2/+2
| | | | | | For the --unattended + --cloud-init conflict Signed-off-by: Cole Robinson <crobinso@redhat.com>
* virt-install: --unattended and --cloud-init conflictCole Robinson2022-08-212-0/+4
| | | | | | | | | Make it an explicit error, otherwise unattended is preferred and cloud-init is ignored https://bugzilla.redhat.com/show_bug.cgi?id=2117157 Signed-off-by: Cole Robinson <crobinso@redhat.com>
* cloner: Sync <uuid> and <sysinfo> system uuidCole Robinson2022-08-214-2/+19
| | | | | | | | | | Otherwise libvirt errors like: ERROR UUID mismatch between <uuid> and <sysinfo> https://bugzilla.redhat.com/show_bug.cgi?id=2038040 Signed-off-by: Cole Robinson <crobinso@redhat.com>
* virt-install: --help required options are wrongCole Robinson2022-08-211-1/+1
| | | | | | | | | | Nowadays it could be as simple as `virt-install --install fedora36`. Trying to represent the interdepencies here is not worth it, but let's keep a simple string around to avoid the default parser usage string, which is huge Signed-off-by: Cole Robinson <crobinso@redhat.com>
* cli: --cpu: Add maxphysaddr.{mode,bits} optionsLin Ma2022-08-205-4/+24
| | | | | | | | | | This commit added support for cpu physical address bits control, It's useful for VMs with huge amount of ram. E.g. --cpu Cascadelake-Server,maxphysaddr.mode=emulate,maxphysaddr.bits=46 Signed-off-by: Lin Ma <lma@suse.com>
* tests: Add a compat check for linux2020 in amd-sev test caseLin Ma2022-08-201-1/+1
| | | | | | It avoids amd-sev test failure if using older osinfo-db. Signed-off-by: Lin Ma <lma@suse.com>
* virtinstall: fix regression with --boot and no install methodCole Robinson2022-08-202-1/+3
| | | | | | | | | | Anything passed to --boot should imply --install no_install=yes in the absence of other --install options. This is historically what we've done but we regressed in 4.1.0 Resolves: https://github.com/virt-manager/virt-manager/issues/426 Signed-off-by: Cole Robinson <crobinso@redhat.com>
* virtinstall: split no_install conditional apart to track code coverageCole Robinson2022-08-202-5/+11
| | | | | | | Each bit here is part of the CLI API, we need to be sure we are covering each one. Extend the test suite to hit one case we are missing Signed-off-by: Cole Robinson <crobinso@redhat.com>
* tests: testdriver: Add filesystem socket exampleCole Robinson2022-08-171-0/+7
| | | | Signed-off-by: Cole Robinson <crobinso@redhat.com>
* cli: Drop unnecessary --disk prop aliasesCole Robinson2022-08-171-2/+0
| | | | Signed-off-by: Cole Robinson <crobinso@redhat.com>
* fsdetails: Fix an error with source.socket of virtiofsLin Ma2022-08-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | Using the source.socket of virtiofs needs a virtiofsd daemon launched outside of libvirtd, So the filesystem UI doesn't support it yet. If users need it they can set it manually in the XML editor. But if we view the filesystem info of such a VM on the details page, It fails with this error message: Traceback (most recent call last): File "/usr/share/virt-manager/virtManager/details/details.py", line 1713, in _refresh_page self._refresh_filesystem_page(dev) File "/usr/share/virt-manager/virtManager/details/details.py", line 2241, in _refresh_filesystem_page self.fsDetails.set_dev(dev) File "/usr/share/virt-manager/virtManager/device/fsdetails.py", line 193, in set_dev self.widget("fs-source").set_text(dev.source) TypeError: Argument 1 does not allow None as a value This patch fixes above issue by leaving the 'source path' info blank in case of source.socket. In this case, Considering that showing 'target path' info without source info is kind of meaningless, So this patch leaves the 'target path' info blank as well. Signed-off-by: Lin Ma <lma@suse.com>
* tests: cli: Fix test output after previous commitCole Robinson2022-08-171-1/+1
| | | | Signed-off-by: Cole Robinson <crobinso@redhat.com>
* cli: --disk: Add driver.metadata_cache optionsLin Ma2022-08-174-0/+22
| | | | | | | | | | | | | | | | | | | Properly setting the metadata cache size can provide better performance in case of using big qcow2 images. This patch introduces two driver options: * driver.metadata_cache.max_size * driver.metadata_cache.max_size.unit E.g. --disk ...,driver.type=qcow2,\ driver.metadata_cache.max_size=2,\ driver.metadata_cache.max_size.unit=MiB BTW, Metadata cache size control is currently supported only for qcow2. Regarding how to properly caluclate the cache size of qcow2, Please refer to qemu's documentation. Signed-off-by: Lin Ma <lma@suse.com>
* Prep for release 4.1.0v4.1.0Cole Robinson2022-08-044-2/+11
| | | | Signed-off-by: Cole Robinson <crobinso@redhat.com>
* po: Refresh translation templatetranslationsCole Robinson2022-08-041-457/+469
| | | | Signed-off-by: Cole Robinson <crobinso@redhat.com>
* Translated using Weblate (Croatian)Gogo Gogsi2022-08-041-546/+574
| | | | | | | | | | | | | | Currently translated at 38.2% (555 of 1451 strings) Translation: virt-manager/virt-manager Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/hr/ Translated using Weblate (Croatian) Currently translated at 8.6% (125 of 1451 strings) Translation: virt-manager/virt-manager Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/hr/
* Translated using Weblate (Chinese (Traditional) (zh_TW))Kisaragi Hiu2022-08-041-273/+222
| | | | | | | | | | | | | | | | | | | | | Currently translated at 99.7% (1447 of 1451 strings) Translation: virt-manager/virt-manager Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/zh_TW/ Translated using Weblate (Chinese (Traditional) (zh_TW)) Currently translated at 99.7% (1447 of 1451 strings) Translation: virt-manager/virt-manager Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/zh_TW/ Translated using Weblate (Chinese (Traditional) (zh_TW)) Currently translated at 98.7% (1433 of 1451 strings) Translation: virt-manager/virt-manager Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/zh_TW/
* Translated using Weblate (German)Ettore Atalan2022-08-041-16/+9
| | | | | | | Currently translated at 82.1% (1192 of 1451 strings) Translation: virt-manager/virt-manager Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/de/
* Translated using Weblate (Korean)김인수2022-08-041-29/+30
| | | | | | | | | | | | | | Currently translated at 100.0% (1451 of 1451 strings) Translation: virt-manager/virt-manager Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/ko/ Translated using Weblate (Korean) Currently translated at 100.0% (1451 of 1451 strings) Translation: virt-manager/virt-manager Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/ko/
* Translated using Weblate (Danish)Morten Abildgaard2022-08-041-49/+51
| | | | | | | Currently translated at 18.3% (266 of 1451 strings) Translation: virt-manager/virt-manager Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/da/
View Lorry Controller Status