diff options
| author | Cole Robinson <crobinso@redhat.com> | 2022-12-13 13:49:35 -0500 |
|---|---|---|
| committer | Cole Robinson <crobinso@redhat.com> | 2022-12-13 13:49:35 -0500 |
| commit | 67832d3097cd6451833c30452d6991896e05933c (patch) | |
| tree | 9afafd1cb67b1ffbb16524b97d9fc6c71fc97513 | |
| parent | 75a25e37660c5578587f4a7a75917cf98d77cf7e (diff) | |
| download | virt-manager-67832d3097cd6451833c30452d6991896e05933c.tar.gz | |
addhardware: Fix backtrace when controller.index is None
When creating a new VM, in the customize wizard we can't depend on
index= value being set (virtinst doesn't do it for example).
For example, this causes a backtrace when adding two virtio-scsi
controllers via the Customize wizard, or adding an extra
virtio-scsi controller to an aarch64 CDROM install.
Reported-by: Charles Arnold <carnold@suse.com>
Signed-off-by: Cole Robinson <crobinso@redhat.com>
| -rw-r--r-- | virtManager/addhardware.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/virtManager/addhardware.py b/virtManager/addhardware.py index aec48dd2..a1dd3261 100644 --- a/virtManager/addhardware.py +++ b/virtManager/addhardware.py @@ -1560,7 +1560,7 @@ class vmmAddHardware(vmmGObjectUI): controller_num = [x for x in controllers if (x.type == controller_type)] if len(controller_num) > 0: - index_new = max(x.index for x in controller_num) + 1 + index_new = max(int(x.index or 0) for x in controller_num) + 1 dev.index = index_new dev.type = controller_type |