diff options
| author | Eike Ziller <eike.ziller@qt.io> | 2023-05-17 12:04:09 +0200 |
|---|---|---|
| committer | Eike Ziller <eike.ziller@qt.io> | 2023-05-17 10:58:02 +0000 |
| commit | c7bf77ae72d27f6bada34eea184ca283a4a113f9 (patch) | |
| tree | 99b08458f88ad02671a617075b2e2def198b4920 /src | |
| parent | a468bc2f029e50c0516eb712d09562c80ee1bdb1 (diff) | |
| download | qt-creator-c7bf77ae72d27f6bada34eea184ca283a4a113f9.tar.gz | |
CheckableMessageBox: Make semantics of bool value clearer
Change-Id: I06a43ab986e6f028cf07ea5e9700c831a591cbf2
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Diffstat (limited to 'src')
| -rw-r--r-- | src/libs/utils/checkablemessagebox.cpp | 6 | ||||
| -rw-r--r-- | src/libs/utils/checkablemessagebox.h | 6 |
2 files changed, 6 insertions, 6 deletions
diff --git a/src/libs/utils/checkablemessagebox.cpp b/src/libs/utils/checkablemessagebox.cpp index 92b111ed7c..29951fd9c4 100644 --- a/src/libs/utils/checkablemessagebox.cpp +++ b/src/libs/utils/checkablemessagebox.cpp @@ -70,7 +70,7 @@ static QMessageBox::StandardButton exec( using T = std::decay_t<decltype(decider)>; msgBox.checkBox()->setText(decider.text); if constexpr (std::is_same_v<T, CheckableMessageBox::BoolDecision>) { - msgBox.checkBox()->setChecked(decider.value); + msgBox.checkBox()->setChecked(decider.doNotAskAgain); } else if constexpr (std::is_same_v<T, CheckableMessageBox::SettingsDecision>) { msgBox.checkBox()->setChecked( decider.settings->value(decider.settingsSubKey, false).toBool()); @@ -142,7 +142,7 @@ void CheckableMessageBox::doNotAskAgain(Decider &decider) [](auto &&decider) { using T = std::decay_t<decltype(decider)>; if constexpr (std::is_same_v<T, BoolDecision>) { - decider.value = true; + decider.doNotAskAgain = true; } else if constexpr (std::is_same_v<T, SettingsDecision>) { decider.settings->beginGroup(QLatin1String(kDoNotAskAgainKey)); decider.settings->setValue(decider.settingsSubKey, true); @@ -160,7 +160,7 @@ bool CheckableMessageBox::shouldAskAgain(const Decider &decider) [](auto &&decider) { using T = std::decay_t<decltype(decider)>; if constexpr (std::is_same_v<T, BoolDecision>) { - return !decider.value; + return !decider.doNotAskAgain; } else if constexpr (std::is_same_v<T, SettingsDecision>) { decider.settings->beginGroup(QLatin1String(kDoNotAskAgainKey)); bool shouldNotAsk = decider.settings->value(decider.settingsSubKey, false).toBool(); diff --git a/src/libs/utils/checkablemessagebox.h b/src/libs/utils/checkablemessagebox.h index e6988fc8e9..1f4c84e1a7 100644 --- a/src/libs/utils/checkablemessagebox.h +++ b/src/libs/utils/checkablemessagebox.h @@ -23,7 +23,7 @@ public: struct BoolDecision { QString text; - bool &value; + bool &doNotAskAgain; }; struct SettingsDecision @@ -48,9 +48,9 @@ public: return Decider{SettingsDecision{text, settings, settingsSubKey}}; } - static Decider make_decider(bool &value, const QString &text = msgDoNotAskAgain()) + static Decider make_decider(bool &doNotAskAgain, const QString &text = msgDoNotAskAgain()) { - return Decider{BoolDecision{text, value}}; + return Decider{BoolDecision{text, doNotAskAgain}}; } static Decider make_decider(BoolAspect &aspect, const QString &text = msgDoNotAskAgain()) |