From c7bf77ae72d27f6bada34eea184ca283a4a113f9 Mon Sep 17 00:00:00 2001
From: Eike Ziller <eike.ziller@qt.io>
Date: Wed, 17 May 2023 12:04:09 +0200
Subject: CheckableMessageBox: Make semantics of bool value clearer

Change-Id: I06a43ab986e6f028cf07ea5e9700c831a591cbf2
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
---
 src/libs/utils/checkablemessagebox.cpp | 6 +++---
 src/libs/utils/checkablemessagebox.h   | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

(limited to 'src')

diff --git a/src/libs/utils/checkablemessagebox.cpp b/src/libs/utils/checkablemessagebox.cpp
index 92b111ed7c..29951fd9c4 100644
--- a/src/libs/utils/checkablemessagebox.cpp
+++ b/src/libs/utils/checkablemessagebox.cpp
@@ -70,7 +70,7 @@ static QMessageBox::StandardButton exec(
                 using T = std::decay_t<decltype(decider)>;
                 msgBox.checkBox()->setText(decider.text);
                 if constexpr (std::is_same_v<T, CheckableMessageBox::BoolDecision>) {
-                    msgBox.checkBox()->setChecked(decider.value);
+                    msgBox.checkBox()->setChecked(decider.doNotAskAgain);
                 } else if constexpr (std::is_same_v<T, CheckableMessageBox::SettingsDecision>) {
                     msgBox.checkBox()->setChecked(
                         decider.settings->value(decider.settingsSubKey, false).toBool());
@@ -142,7 +142,7 @@ void CheckableMessageBox::doNotAskAgain(Decider &decider)
         [](auto &&decider) {
             using T = std::decay_t<decltype(decider)>;
             if constexpr (std::is_same_v<T, BoolDecision>) {
-                decider.value = true;
+                decider.doNotAskAgain = true;
             } else if constexpr (std::is_same_v<T, SettingsDecision>) {
                 decider.settings->beginGroup(QLatin1String(kDoNotAskAgainKey));
                 decider.settings->setValue(decider.settingsSubKey, true);
@@ -160,7 +160,7 @@ bool CheckableMessageBox::shouldAskAgain(const Decider &decider)
         [](auto &&decider) {
             using T = std::decay_t<decltype(decider)>;
             if constexpr (std::is_same_v<T, BoolDecision>) {
-                return !decider.value;
+                return !decider.doNotAskAgain;
             } else if constexpr (std::is_same_v<T, SettingsDecision>) {
                 decider.settings->beginGroup(QLatin1String(kDoNotAskAgainKey));
                 bool shouldNotAsk = decider.settings->value(decider.settingsSubKey, false).toBool();
diff --git a/src/libs/utils/checkablemessagebox.h b/src/libs/utils/checkablemessagebox.h
index e6988fc8e9..1f4c84e1a7 100644
--- a/src/libs/utils/checkablemessagebox.h
+++ b/src/libs/utils/checkablemessagebox.h
@@ -23,7 +23,7 @@ public:
     struct BoolDecision
     {
         QString text;
-        bool &value;
+        bool &doNotAskAgain;
     };
 
     struct SettingsDecision
@@ -48,9 +48,9 @@ public:
         return Decider{SettingsDecision{text, settings, settingsSubKey}};
     }
 
-    static Decider make_decider(bool &value, const QString &text = msgDoNotAskAgain())
+    static Decider make_decider(bool &doNotAskAgain, const QString &text = msgDoNotAskAgain())
     {
-        return Decider{BoolDecision{text, value}};
+        return Decider{BoolDecision{text, doNotAskAgain}};
     }
 
     static Decider make_decider(BoolAspect &aspect, const QString &text = msgDoNotAskAgain())
-- 
cgit v1.2.1