diff options
| author | Tobias Hunger <tobias.hunger@qt.io> | 2019-06-20 15:51:04 +0200 |
|---|---|---|
| committer | Tobias Hunger <tobias.hunger@qt.io> | 2019-06-20 14:40:55 +0000 |
| commit | add60c014871bdae0a038398695425a347b44952 (patch) | |
| tree | 71eec14fa7378f9c3313dae1e3b1584c7f7b33da /src/plugins/cmakeprojectmanager/projecttreehelper.cpp | |
| parent | 129c0abb5a38d8f928a122f173ac361f56f2df3e (diff) | |
| download | qt-creator-add60c014871bdae0a038398695425a347b44952.tar.gz | |
CMake: Avoid a bit of useless processing when updating the project tree
Do not pass around a list of filenodes with all the known header files.
That list gets converted into a QSet<FilePath> and then that is used.
Just generate the QSet<FilePath> directly and avoid that conversion.
Change-Id: I2444a2a6b4a1600fe476e66673a1a2e9c8900764
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Diffstat (limited to 'src/plugins/cmakeprojectmanager/projecttreehelper.cpp')
| -rw-r--r-- | src/plugins/cmakeprojectmanager/projecttreehelper.cpp | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/src/plugins/cmakeprojectmanager/projecttreehelper.cpp b/src/plugins/cmakeprojectmanager/projecttreehelper.cpp index 1bc86189d7..58b2f744e8 100644 --- a/src/plugins/cmakeprojectmanager/projecttreehelper.cpp +++ b/src/plugins/cmakeprojectmanager/projecttreehelper.cpp @@ -174,7 +174,7 @@ CMakeTargetNode *createTargetNode(const QHash<Utils::FilePath, ProjectNode *> &c } void addHeaderNodes(ProjectNode *root, - const QVector<FileNode *> knownHeaders, + QSet<Utils::FilePath> &seenHeaders, const QList<const FileNode *> &allFiles) { if (root->isEmpty()) @@ -188,9 +188,6 @@ void addHeaderNodes(ProjectNode *root, QCoreApplication::translate("CMakeProjectManager::Internal::ServerModeReader", "<Headers>")); headerNode->setIcon(headerNodeIcon); - // knownHeaders are already listed in their targets: - QSet<Utils::FilePath> seenHeaders = Utils::transform<QSet>(knownHeaders, &FileNode::filePath); - // Add scanned headers: for (const FileNode *fn : allFiles) { if (fn->fileType() != FileType::Header || !fn->filePath().isChildOf(root->filePath())) |