From add60c014871bdae0a038398695425a347b44952 Mon Sep 17 00:00:00 2001 From: Tobias Hunger Date: Thu, 20 Jun 2019 15:51:04 +0200 Subject: CMake: Avoid a bit of useless processing when updating the project tree Do not pass around a list of filenodes with all the known header files. That list gets converted into a QSet and then that is used. Just generate the QSet directly and avoid that conversion. Change-Id: I2444a2a6b4a1600fe476e66673a1a2e9c8900764 Reviewed-by: Cristian Adam Reviewed-by: hjk --- src/plugins/cmakeprojectmanager/projecttreehelper.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'src/plugins/cmakeprojectmanager/projecttreehelper.cpp') diff --git a/src/plugins/cmakeprojectmanager/projecttreehelper.cpp b/src/plugins/cmakeprojectmanager/projecttreehelper.cpp index 1bc86189d7..58b2f744e8 100644 --- a/src/plugins/cmakeprojectmanager/projecttreehelper.cpp +++ b/src/plugins/cmakeprojectmanager/projecttreehelper.cpp @@ -174,7 +174,7 @@ CMakeTargetNode *createTargetNode(const QHash &c } void addHeaderNodes(ProjectNode *root, - const QVector knownHeaders, + QSet &seenHeaders, const QList &allFiles) { if (root->isEmpty()) @@ -188,9 +188,6 @@ void addHeaderNodes(ProjectNode *root, QCoreApplication::translate("CMakeProjectManager::Internal::ServerModeReader", "")); headerNode->setIcon(headerNodeIcon); - // knownHeaders are already listed in their targets: - QSet seenHeaders = Utils::transform(knownHeaders, &FileNode::filePath); - // Add scanned headers: for (const FileNode *fn : allFiles) { if (fn->fileType() != FileType::Header || !fn->filePath().isChildOf(root->filePath())) -- cgit v1.2.1