diff options
| author | Orgad Shaneh <orgad.shaneh@audiocodes.com> | 2014-05-19 23:31:01 +0300 |
|---|---|---|
| committer | Orgad Shaneh <orgads@gmail.com> | 2015-02-11 07:34:29 +0000 |
| commit | 85ed66bae94dcb87dcd948bfca1dbc4c12042226 (patch) | |
| tree | 80289c84242a229ca30d49d54e0937375ee08b18 /src/plugins/android/androidmanifesteditorwidget.h | |
| parent | 772c2caac9a2c2b0df20ce59c4fe18e5af96773f (diff) | |
| download | qt-creator-85ed66bae94dcb87dcd948bfca1dbc4c12042226.tar.gz | |
Android: Pass some values by reference
Change-Id: Ic12452320728b161afd2907deb036d0c6d9df644
Reviewed-by: BogDan Vatra <bogdan@kde.org>
Diffstat (limited to 'src/plugins/android/androidmanifesteditorwidget.h')
| -rw-r--r-- | src/plugins/android/androidmanifesteditorwidget.h | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/src/plugins/android/androidmanifesteditorwidget.h b/src/plugins/android/androidmanifesteditorwidget.h index b947700857..20b578ccd4 100644 --- a/src/plugins/android/androidmanifesteditorwidget.h +++ b/src/plugins/android/androidmanifesteditorwidget.h @@ -69,7 +69,7 @@ public: void setPermissions(const QStringList &permissions); const QStringList &permissions(); QModelIndex addPermission(const QString &permission); - bool updatePermission(QModelIndex index, const QString &permission); + bool updatePermission(const QModelIndex &index, const QString &permission); void removePermission(int index); QVariant data(const QModelIndex &index, int role) const; @@ -137,7 +137,8 @@ private: void syncToWidgets(const QDomDocument &doc); void syncToEditor(); - bool checkDocument(QDomDocument doc, QString *errorMessage, int *errorLine, int *errorColumn); + bool checkDocument(const QDomDocument &doc, QString *errorMessage, + int *errorLine, int *errorColumn); enum IconDPI { LowDPI, MediumDPI, HighDPI }; QIcon icon(const QString &baseDir, IconDPI dpi); QString iconPath(const QString &baseDir, IconDPI dpi); @@ -152,7 +153,9 @@ private: void parseActivity(QXmlStreamReader &reader, QXmlStreamWriter &writer); bool parseMetaData(QXmlStreamReader &reader, QXmlStreamWriter &writer); void parseUsesSdk(QXmlStreamReader &reader, QXmlStreamWriter &writer); - QString parseUsesPermission(QXmlStreamReader &reader, QXmlStreamWriter &writer, const QSet<QString> permissions); + QString parseUsesPermission(QXmlStreamReader &reader, + QXmlStreamWriter &writer, + const QSet<QString> &permissions); QString parseComment(QXmlStreamReader &reader, QXmlStreamWriter &writer); void parseUnknownElement(QXmlStreamReader &reader, QXmlStreamWriter &writer); |