From 85ed66bae94dcb87dcd948bfca1dbc4c12042226 Mon Sep 17 00:00:00 2001 From: Orgad Shaneh Date: Mon, 19 May 2014 23:31:01 +0300 Subject: Android: Pass some values by reference Change-Id: Ic12452320728b161afd2907deb036d0c6d9df644 Reviewed-by: BogDan Vatra --- src/plugins/android/androidmanifesteditorwidget.h | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) (limited to 'src/plugins/android/androidmanifesteditorwidget.h') diff --git a/src/plugins/android/androidmanifesteditorwidget.h b/src/plugins/android/androidmanifesteditorwidget.h index b947700857..20b578ccd4 100644 --- a/src/plugins/android/androidmanifesteditorwidget.h +++ b/src/plugins/android/androidmanifesteditorwidget.h @@ -69,7 +69,7 @@ public: void setPermissions(const QStringList &permissions); const QStringList &permissions(); QModelIndex addPermission(const QString &permission); - bool updatePermission(QModelIndex index, const QString &permission); + bool updatePermission(const QModelIndex &index, const QString &permission); void removePermission(int index); QVariant data(const QModelIndex &index, int role) const; @@ -137,7 +137,8 @@ private: void syncToWidgets(const QDomDocument &doc); void syncToEditor(); - bool checkDocument(QDomDocument doc, QString *errorMessage, int *errorLine, int *errorColumn); + bool checkDocument(const QDomDocument &doc, QString *errorMessage, + int *errorLine, int *errorColumn); enum IconDPI { LowDPI, MediumDPI, HighDPI }; QIcon icon(const QString &baseDir, IconDPI dpi); QString iconPath(const QString &baseDir, IconDPI dpi); @@ -152,7 +153,9 @@ private: void parseActivity(QXmlStreamReader &reader, QXmlStreamWriter &writer); bool parseMetaData(QXmlStreamReader &reader, QXmlStreamWriter &writer); void parseUsesSdk(QXmlStreamReader &reader, QXmlStreamWriter &writer); - QString parseUsesPermission(QXmlStreamReader &reader, QXmlStreamWriter &writer, const QSet permissions); + QString parseUsesPermission(QXmlStreamReader &reader, + QXmlStreamWriter &writer, + const QSet &permissions); QString parseComment(QXmlStreamReader &reader, QXmlStreamWriter &writer); void parseUnknownElement(QXmlStreamReader &reader, QXmlStreamWriter &writer); -- cgit v1.2.1