summaryrefslogtreecommitdiff
path: root/src/libs/utils/shellcommand.cpp
diff options
context:
space:
mode:
authorAlessandro Portale <alessandro.portale@qt.io>2019-01-16 18:06:21 +0100
committerAlessandro Portale <alessandro.portale@qt.io>2019-01-17 15:54:56 +0000
commit616e19ff9e91a9ce8a1ee379553f9325beed035d (patch)
tree95ec85f7d1993fae787e2668434df8ea1f13deac /src/libs/utils/shellcommand.cpp
parent710e57a628c90259297150ab3a0ac28e315ca1af (diff)
downloadqt-creator-616e19ff9e91a9ce8a1ee379553f9325beed035d.tar.gz
Fix warning: "Missing emit keyword on signal call"
[-Wclazy-incorrect-emit] Change-Id: I93bdc6e23cdaccf35c9899ae16870ccc65a54f80 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Diffstat (limited to 'src/libs/utils/shellcommand.cpp')
-rw-r--r--src/libs/utils/shellcommand.cpp16
1 files changed, 8 insertions, 8 deletions
diff --git a/src/libs/utils/shellcommand.cpp b/src/libs/utils/shellcommand.cpp
index 0d5be90996..14f52d2539 100644
--- a/src/libs/utils/shellcommand.cpp
+++ b/src/libs/utils/shellcommand.cpp
@@ -336,7 +336,7 @@ SynchronousProcessResponse ShellCommand::runCommand(const FileName &binary,
QSharedPointer<OutputProxy> proxy(d->m_proxyFactory());
if (!(d->m_flags & SuppressCommandLogging))
- proxy->appendCommand(dir, binary, arguments);
+ emit proxy->appendCommand(dir, binary, arguments);
if ((d->m_flags & FullySynchronously)
|| (!(d->m_flags & NoFullySync)
@@ -350,9 +350,9 @@ SynchronousProcessResponse ShellCommand::runCommand(const FileName &binary,
// Success/Fail message in appropriate window?
if (response.result == SynchronousProcessResponse::Finished) {
if (d->m_flags & ShowSuccessMessage)
- proxy->appendMessage(response.exitMessage(binary.toUserOutput(), timeoutS));
+ emit proxy->appendMessage(response.exitMessage(binary.toUserOutput(), timeoutS));
} else if (!(d->m_flags & SuppressFailMessage)) {
- proxy->appendError(response.exitMessage(binary.toUserOutput(), timeoutS));
+ emit proxy->appendError(response.exitMessage(binary.toUserOutput(), timeoutS));
}
}
@@ -385,14 +385,14 @@ SynchronousProcessResponse ShellCommand::runFullySynchronous(const FileName &bin
if (!d->m_aborted) {
const QString stdErr = resp.stdErr();
if (!stdErr.isEmpty() && !(d->m_flags & SuppressStdErr))
- proxy->append(stdErr);
+ emit proxy->append(stdErr);
const QString stdOut = resp.stdOut();
if (!stdOut.isEmpty() && d->m_flags & ShowStdOut) {
if (d->m_flags & SilentOutput)
- proxy->appendSilently(stdOut);
+ emit proxy->appendSilently(stdOut);
else
- proxy->append(stdOut);
+ emit proxy->append(stdOut);
}
}
@@ -430,7 +430,7 @@ SynchronousProcessResponse ShellCommand::runSynchronous(const FileName &binary,
if (d->m_progressParser)
d->m_progressParser->parseProgress(text);
if (!(d->m_flags & SuppressStdErr))
- proxy->appendError(text);
+ emit proxy->appendError(text);
if (d->m_progressiveOutput)
emit stdErrText(text);
});
@@ -445,7 +445,7 @@ SynchronousProcessResponse ShellCommand::runSynchronous(const FileName &binary,
if (d->m_progressParser)
d->m_progressParser->parseProgress(text);
if (d->m_flags & ShowStdOut)
- proxy->append(text);
+ emit proxy->append(text);
if (d->m_progressiveOutput) {
emit stdOutText(text);
d->m_hadOutput = true;