diff options
author | Alessandro Portale <alessandro.portale@qt.io> | 2019-01-16 18:06:21 +0100 |
---|---|---|
committer | Alessandro Portale <alessandro.portale@qt.io> | 2019-01-17 15:54:56 +0000 |
commit | 616e19ff9e91a9ce8a1ee379553f9325beed035d (patch) | |
tree | 95ec85f7d1993fae787e2668434df8ea1f13deac /src/libs/utils | |
parent | 710e57a628c90259297150ab3a0ac28e315ca1af (diff) | |
download | qt-creator-616e19ff9e91a9ce8a1ee379553f9325beed035d.tar.gz |
Fix warning: "Missing emit keyword on signal call"
[-Wclazy-incorrect-emit]
Change-Id: I93bdc6e23cdaccf35c9899ae16870ccc65a54f80
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Diffstat (limited to 'src/libs/utils')
-rw-r--r-- | src/libs/utils/shellcommand.cpp | 16 | ||||
-rw-r--r-- | src/libs/utils/treemodel.cpp | 11 |
2 files changed, 14 insertions, 13 deletions
diff --git a/src/libs/utils/shellcommand.cpp b/src/libs/utils/shellcommand.cpp index 0d5be90996..14f52d2539 100644 --- a/src/libs/utils/shellcommand.cpp +++ b/src/libs/utils/shellcommand.cpp @@ -336,7 +336,7 @@ SynchronousProcessResponse ShellCommand::runCommand(const FileName &binary, QSharedPointer<OutputProxy> proxy(d->m_proxyFactory()); if (!(d->m_flags & SuppressCommandLogging)) - proxy->appendCommand(dir, binary, arguments); + emit proxy->appendCommand(dir, binary, arguments); if ((d->m_flags & FullySynchronously) || (!(d->m_flags & NoFullySync) @@ -350,9 +350,9 @@ SynchronousProcessResponse ShellCommand::runCommand(const FileName &binary, // Success/Fail message in appropriate window? if (response.result == SynchronousProcessResponse::Finished) { if (d->m_flags & ShowSuccessMessage) - proxy->appendMessage(response.exitMessage(binary.toUserOutput(), timeoutS)); + emit proxy->appendMessage(response.exitMessage(binary.toUserOutput(), timeoutS)); } else if (!(d->m_flags & SuppressFailMessage)) { - proxy->appendError(response.exitMessage(binary.toUserOutput(), timeoutS)); + emit proxy->appendError(response.exitMessage(binary.toUserOutput(), timeoutS)); } } @@ -385,14 +385,14 @@ SynchronousProcessResponse ShellCommand::runFullySynchronous(const FileName &bin if (!d->m_aborted) { const QString stdErr = resp.stdErr(); if (!stdErr.isEmpty() && !(d->m_flags & SuppressStdErr)) - proxy->append(stdErr); + emit proxy->append(stdErr); const QString stdOut = resp.stdOut(); if (!stdOut.isEmpty() && d->m_flags & ShowStdOut) { if (d->m_flags & SilentOutput) - proxy->appendSilently(stdOut); + emit proxy->appendSilently(stdOut); else - proxy->append(stdOut); + emit proxy->append(stdOut); } } @@ -430,7 +430,7 @@ SynchronousProcessResponse ShellCommand::runSynchronous(const FileName &binary, if (d->m_progressParser) d->m_progressParser->parseProgress(text); if (!(d->m_flags & SuppressStdErr)) - proxy->appendError(text); + emit proxy->appendError(text); if (d->m_progressiveOutput) emit stdErrText(text); }); @@ -445,7 +445,7 @@ SynchronousProcessResponse ShellCommand::runSynchronous(const FileName &binary, if (d->m_progressParser) d->m_progressParser->parseProgress(text); if (d->m_flags & ShowStdOut) - proxy->append(text); + emit proxy->append(text); if (d->m_progressiveOutput) { emit stdOutText(text); d->m_hadOutput = true; diff --git a/src/libs/utils/treemodel.cpp b/src/libs/utils/treemodel.cpp index 0d587dddbc..1f8fbd5756 100644 --- a/src/libs/utils/treemodel.cpp +++ b/src/libs/utils/treemodel.cpp @@ -748,7 +748,8 @@ void TreeItem::update() { if (m_model) { QModelIndex idx = index(); - m_model->dataChanged(idx.sibling(idx.row(), 0), idx.sibling(idx.row(), m_model->m_columnCount - 1)); + emit m_model->dataChanged(idx.sibling(idx.row(), 0), + idx.sibling(idx.row(), m_model->m_columnCount - 1)); } } @@ -756,7 +757,7 @@ void TreeItem::updateAll() { if (m_model) { QModelIndex idx = index(); - m_model->dataChanged(idx, idx.sibling(idx.row(), m_model->m_columnCount - 1)); + emit m_model->dataChanged(idx, idx.sibling(idx.row(), m_model->m_columnCount - 1)); for (TreeItem *item : *this) item->updateAll(); } @@ -766,7 +767,7 @@ void TreeItem::updateColumn(int column) { if (m_model) { QModelIndex idx = index(); - m_model->dataChanged(idx.sibling(idx.row(), column), idx.sibling(idx.row(), column)); + emit m_model->dataChanged(idx.sibling(idx.row(), column), idx.sibling(idx.row(), column)); } } @@ -893,13 +894,13 @@ void TreeItem::removeItemAt(int pos) void TreeItem::expand() { QTC_ASSERT(m_model, return); - m_model->requestExpansion(index()); + emit m_model->requestExpansion(index()); } void TreeItem::collapse() { QTC_ASSERT(m_model, return); - m_model->requestCollapse(index()); + emit m_model->requestCollapse(index()); } void TreeItem::propagateModel(BaseTreeModel *m) |