summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorhjk <hjk@qt.io>2023-05-08 14:09:09 +0200
committerhjk <hjk@qt.io>2023-05-08 12:27:32 +0000
commit851f317199ec15a6cf0483580c09efa2ab9bde58 (patch)
tree4e9f5b79b8d7c7d77716b4f6f44891f7298b783b
parentbd660aaf27e131c069fb779db556a962c067fdf4 (diff)
downloadqt-creator-851f317199ec15a6cf0483580c09efa2ab9bde58.tar.gz
Core: Remove parent pointer from IOptionPage constructor
Not used anymore. Change-Id: Ic44ce021b1f952337a3193454b5b6649d5847446 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
-rw-r--r--src/plugins/coreplugin/dialogs/ioptionspage.cpp3
-rw-r--r--src/plugins/coreplugin/dialogs/ioptionspage.h2
-rw-r--r--src/plugins/designer/settingspage.cpp4
3 files changed, 4 insertions, 5 deletions
diff --git a/src/plugins/coreplugin/dialogs/ioptionspage.cpp b/src/plugins/coreplugin/dialogs/ioptionspage.cpp
index 451859c527..f7657498ca 100644
--- a/src/plugins/coreplugin/dialogs/ioptionspage.cpp
+++ b/src/plugins/coreplugin/dialogs/ioptionspage.cpp
@@ -240,8 +240,7 @@ static QList<IOptionsPage *> g_optionsPages;
Constructs an options page with the given \a parent and registers it
at the global options page pool if \a registerGlobally is \c true.
*/
-IOptionsPage::IOptionsPage(QObject *parent, bool registerGlobally)
- : QObject(parent)
+IOptionsPage::IOptionsPage(bool registerGlobally)
{
if (registerGlobally)
g_optionsPages.append(this);
diff --git a/src/plugins/coreplugin/dialogs/ioptionspage.h b/src/plugins/coreplugin/dialogs/ioptionspage.h
index 8aa2ed6641..21b5a6ec44 100644
--- a/src/plugins/coreplugin/dialogs/ioptionspage.h
+++ b/src/plugins/coreplugin/dialogs/ioptionspage.h
@@ -42,7 +42,7 @@ class CORE_EXPORT IOptionsPage : public QObject
Q_OBJECT
public:
- IOptionsPage(QObject *parent = nullptr, bool registerGlobally = true);
+ explicit IOptionsPage(bool registerGlobally = true);
~IOptionsPage() override;
static const QList<IOptionsPage *> allOptionsPages();
diff --git a/src/plugins/designer/settingspage.cpp b/src/plugins/designer/settingspage.cpp
index c393503d5c..e1998ffd5e 100644
--- a/src/plugins/designer/settingspage.cpp
+++ b/src/plugins/designer/settingspage.cpp
@@ -34,8 +34,8 @@ public:
};
-SettingsPage::SettingsPage(QDesignerOptionsPageInterface *designerPage) :
- Core::IOptionsPage(nullptr, false)
+SettingsPage::SettingsPage(QDesignerOptionsPageInterface *designerPage)
+ : Core::IOptionsPage(false)
{
setId(Utils::Id::fromString(designerPage->name()));
setDisplayName(designerPage->name());