From 851f317199ec15a6cf0483580c09efa2ab9bde58 Mon Sep 17 00:00:00 2001 From: hjk Date: Mon, 8 May 2023 14:09:09 +0200 Subject: Core: Remove parent pointer from IOptionPage constructor Not used anymore. Change-Id: Ic44ce021b1f952337a3193454b5b6649d5847446 Reviewed-by: Eike Ziller --- src/plugins/coreplugin/dialogs/ioptionspage.cpp | 3 +-- src/plugins/coreplugin/dialogs/ioptionspage.h | 2 +- src/plugins/designer/settingspage.cpp | 4 ++-- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/plugins/coreplugin/dialogs/ioptionspage.cpp b/src/plugins/coreplugin/dialogs/ioptionspage.cpp index 451859c527..f7657498ca 100644 --- a/src/plugins/coreplugin/dialogs/ioptionspage.cpp +++ b/src/plugins/coreplugin/dialogs/ioptionspage.cpp @@ -240,8 +240,7 @@ static QList g_optionsPages; Constructs an options page with the given \a parent and registers it at the global options page pool if \a registerGlobally is \c true. */ -IOptionsPage::IOptionsPage(QObject *parent, bool registerGlobally) - : QObject(parent) +IOptionsPage::IOptionsPage(bool registerGlobally) { if (registerGlobally) g_optionsPages.append(this); diff --git a/src/plugins/coreplugin/dialogs/ioptionspage.h b/src/plugins/coreplugin/dialogs/ioptionspage.h index 8aa2ed6641..21b5a6ec44 100644 --- a/src/plugins/coreplugin/dialogs/ioptionspage.h +++ b/src/plugins/coreplugin/dialogs/ioptionspage.h @@ -42,7 +42,7 @@ class CORE_EXPORT IOptionsPage : public QObject Q_OBJECT public: - IOptionsPage(QObject *parent = nullptr, bool registerGlobally = true); + explicit IOptionsPage(bool registerGlobally = true); ~IOptionsPage() override; static const QList allOptionsPages(); diff --git a/src/plugins/designer/settingspage.cpp b/src/plugins/designer/settingspage.cpp index c393503d5c..e1998ffd5e 100644 --- a/src/plugins/designer/settingspage.cpp +++ b/src/plugins/designer/settingspage.cpp @@ -34,8 +34,8 @@ public: }; -SettingsPage::SettingsPage(QDesignerOptionsPageInterface *designerPage) : - Core::IOptionsPage(nullptr, false) +SettingsPage::SettingsPage(QDesignerOptionsPageInterface *designerPage) + : Core::IOptionsPage(false) { setId(Utils::Id::fromString(designerPage->name())); setDisplayName(designerPage->name()); -- cgit v1.2.1