summaryrefslogtreecommitdiff
path: root/Lib/test
diff options
context:
space:
mode:
Diffstat (limited to 'Lib/test')
-rw-r--r--Lib/test/test_tarfile.py14
1 files changed, 14 insertions, 0 deletions
diff --git a/Lib/test/test_tarfile.py b/Lib/test/test_tarfile.py
index cfdda24a26..e4b5c52bf1 100644
--- a/Lib/test/test_tarfile.py
+++ b/Lib/test/test_tarfile.py
@@ -20,6 +20,10 @@ try:
except ImportError:
gzip = None
try:
+ import zlib
+except ImportError:
+ zlib = None
+try:
import bz2
except ImportError:
bz2 = None
@@ -687,6 +691,16 @@ class MiscReadTestBase(CommonReadTest):
self.assertEqual(m1.offset, m2.offset)
self.assertEqual(m1.get_info(), m2.get_info())
+ @unittest.skipIf(zlib is None, "requires zlib")
+ def test_zlib_error_does_not_leak(self):
+ # bpo-39039: tarfile.open allowed zlib exceptions to bubble up when
+ # parsing certain types of invalid data
+ with unittest.mock.patch("tarfile.TarInfo.fromtarfile") as mock:
+ mock.side_effect = zlib.error
+ with self.assertRaises(tarfile.ReadError):
+ tarfile.open(self.tarname)
+
+
class MiscReadTest(MiscReadTestBase, unittest.TestCase):
test_fail_comp = None