diff options
Diffstat (limited to 'Lib')
-rwxr-xr-x | Lib/tarfile.py | 9 | ||||
-rw-r--r-- | Lib/test/test_tarfile.py | 14 |
2 files changed, 23 insertions, 0 deletions
diff --git a/Lib/tarfile.py b/Lib/tarfile.py index 18d415adf5..c1ee1222e0 100755 --- a/Lib/tarfile.py +++ b/Lib/tarfile.py @@ -2349,6 +2349,15 @@ class TarFile(object): raise ReadError(str(e)) from None except SubsequentHeaderError as e: raise ReadError(str(e)) from None + except Exception as e: + try: + import zlib + if isinstance(e, zlib.error): + raise ReadError(f'zlib error: {e}') from None + else: + raise e + except ImportError: + raise e break if tarinfo is not None: diff --git a/Lib/test/test_tarfile.py b/Lib/test/test_tarfile.py index cfdda24a26..e4b5c52bf1 100644 --- a/Lib/test/test_tarfile.py +++ b/Lib/test/test_tarfile.py @@ -20,6 +20,10 @@ try: except ImportError: gzip = None try: + import zlib +except ImportError: + zlib = None +try: import bz2 except ImportError: bz2 = None @@ -687,6 +691,16 @@ class MiscReadTestBase(CommonReadTest): self.assertEqual(m1.offset, m2.offset) self.assertEqual(m1.get_info(), m2.get_info()) + @unittest.skipIf(zlib is None, "requires zlib") + def test_zlib_error_does_not_leak(self): + # bpo-39039: tarfile.open allowed zlib exceptions to bubble up when + # parsing certain types of invalid data + with unittest.mock.patch("tarfile.TarInfo.fromtarfile") as mock: + mock.side_effect = zlib.error + with self.assertRaises(tarfile.ReadError): + tarfile.open(self.tarname) + + class MiscReadTest(MiscReadTestBase, unittest.TestCase): test_fail_comp = None |