summaryrefslogtreecommitdiff
path: root/virtManager/device/addstorage.py
Commit message (Collapse)AuthorAgeFilesLines
* details: Remove 'detect zeroes' UICole Robinson2022-02-031-19/+1
| | | | | | | | After checking with qemu devs, this option is not really recommended for common usage and doesn't get used much in practice. So I don't think it is suitable for the UI Signed-off-by: Cole Robinson <crobinso@redhat.com>
* addstorage: Don't pass None to widget.set_active()Cole Robinson2020-11-211-1/+1
| | | | | | | Older pygobject can't handle it. Mentioned here: https://github.com/virt-manager/virt-manager/issues/188 Signed-off-by: Cole Robinson <crobinso@redhat.com>
* device: disk: Rename path property to get/set_source_pathCole Robinson2020-11-111-7/+9
| | | | | | | | This makes it more clear that 'path' is really a special designation with a bunch of complicated logic behind it. It's also easier to grep for Signed-off-by: Cole Robinson <crobinso@redhat.com>
* addstorage: Return to using qcow2 sparse by defaultCole Robinson2020-09-201-2/+6
| | | | | | | | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=1759454 See 15a6a7e2105440df528f75c4df4d2471df28bd1e The idea behind virt-manager's sparse vs nonsparse default, is that if the user selected 'raw' for as the default image format, assume they want to maximize performance, so fully allocate the disk. qcow2 didn't support anything except sparse, so the sparse=True vs sparse=False made no difference. So we always set sparse=False Then qcow2 grows non-sparse support, and virt-manager is suddenly defaulting to it, which is not the intention. Default to sparse when requested format isn't raw Signed-off-by: Cole Robinson <crobinso@redhat.com>
* addhardware: Allow settings USB removable settingCole Robinson2020-09-131-9/+9
| | | | | | | | We need to update addstorage when the user changes the bus setting Fixes: #148 Signed-off-by: Cole Robinson <crobinso@redhat.com>
* virtManager: misc reference leak fixesCole Robinson2020-09-081-0/+2
| | | | Signed-off-by: Cole Robinson <crobinso@redhat.com>
* addstorage: Revive disk serial UICole Robinson2020-09-081-1/+10
| | | | | | | coreos is going to start using disk serial for ignition disk, so setting this in the UI for distro testing will become more common Signed-off-by: Cole Robinson <crobinso@redhat.com>
* addstorage: Absorb advanced field UICole Robinson2020-09-081-1/+132
| | | | | | | | | | | | | | | | Share the UI for changing all these disk properties: - shareable - readonly - removable - cache - discard - detect zeroes Move them all under the 'Advanced options' expander in details, and add the checkbox options to the addhardware wizard. Signed-off-by: Cole Robinson <crobinso@redhat.com>
* uitests: Finish addstorage.py coverageCole Robinson2020-08-261-14/+6
| | | | | | | | We need to wire up some craziness to make path permission searching fail, but this is a critical area to get correct so it is worth it Signed-off-by: Cole Robinson <crobinso@redhat.com>
* po: Fix message format warnings printed from xgettextCole Robinson2020-07-111-3/+4
| | | | Signed-off-by: Cole Robinson <crobinso@redhat.com>
* virtManager: Convert to CSS for most color usageCole Robinson2020-02-031-1/+1
| | | | | | | | * Add CSS data in config.py and install it * Strip out all hardcoded colors and use style class annotations * Fix colors to be more theme appropriate to fix dark theme look Signed-off-by: Cole Robinson <crobinso@redhat.com>
* devices: disk: Add more test coverageCole Robinson2020-01-291-2/+1
| | | | Signed-off-by: Cole Robinson <crobinso@redhat.com>
* connection: Remove is_*_capable wrappersCole Robinson2020-01-241-1/+1
| | | | | | | Call the conn.support check directly. Move the check logging to the initial startup path Signed-off-by: Cole Robinson <crobinso@redhat.com>
* storage: Replace volume supports_property with supports_formatCole Robinson2019-07-031-1/+1
| | | | Helps to make usage more explicit
* virtManager: Move a lot of misc files to lib/Cole Robinson2019-06-171-1/+1
|
* virtManager: move device UI files to virtManager/device/Cole Robinson2019-06-171-0/+233