diff options
| author | James E. King, III <jking@apache.org> | 2017-10-28 18:25:45 -0400 |
|---|---|---|
| committer | James E. King, III <jking@apache.org> | 2017-10-29 07:05:47 -0400 |
| commit | 533405e3f85f2925aa1028fc3534e988e5debd32 (patch) | |
| tree | 58073ef89cddef4bcae5e9b731ea028bdf105948 /lib/cpp/test/SecurityTest.cpp | |
| parent | 375bfee701d3caa74074f8afb3d6940e52c45c88 (diff) | |
| download | thrift-533405e3f85f2925aa1028fc3534e988e5debd32.tar.gz | |
THRIFT-4376: fix more high impact coverity defects
Led to the discovery of incorrect lua socket error handling.
This closes #1405
Diffstat (limited to 'lib/cpp/test/SecurityTest.cpp')
| -rw-r--r-- | lib/cpp/test/SecurityTest.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/lib/cpp/test/SecurityTest.cpp b/lib/cpp/test/SecurityTest.cpp index 6eb1fe342..51ee42727 100644 --- a/lib/cpp/test/SecurityTest.cpp +++ b/lib/cpp/test/SecurityTest.cpp @@ -255,11 +255,12 @@ BOOST_AUTO_TEST_CASE(ssl_security_matrix) % protocol2str(si) % protocol2str(ci)); mConnected = false; + // thread_group manages the thread lifetime - ignore the return value of create_thread boost::thread_group threads; - threads.create_thread(bind(&SecurityFixture::server, this, static_cast<apache::thrift::transport::SSLProtocol>(si))); + (void)threads.create_thread(bind(&SecurityFixture::server, this, static_cast<apache::thrift::transport::SSLProtocol>(si))); mCVar.wait(lock); // wait for listen() to succeed lock.unlock(); - threads.create_thread(bind(&SecurityFixture::client, this, static_cast<apache::thrift::transport::SSLProtocol>(ci))); + (void)threads.create_thread(bind(&SecurityFixture::client, this, static_cast<apache::thrift::transport::SSLProtocol>(ci))); threads.join_all(); BOOST_CHECK_MESSAGE(mConnected == matrix[ci][si], |