From 533405e3f85f2925aa1028fc3534e988e5debd32 Mon Sep 17 00:00:00 2001 From: "James E. King, III" Date: Sat, 28 Oct 2017 18:25:45 -0400 Subject: THRIFT-4376: fix more high impact coverity defects Led to the discovery of incorrect lua socket error handling. This closes #1405 --- lib/cpp/test/SecurityTest.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'lib/cpp/test/SecurityTest.cpp') diff --git a/lib/cpp/test/SecurityTest.cpp b/lib/cpp/test/SecurityTest.cpp index 6eb1fe342..51ee42727 100644 --- a/lib/cpp/test/SecurityTest.cpp +++ b/lib/cpp/test/SecurityTest.cpp @@ -255,11 +255,12 @@ BOOST_AUTO_TEST_CASE(ssl_security_matrix) % protocol2str(si) % protocol2str(ci)); mConnected = false; + // thread_group manages the thread lifetime - ignore the return value of create_thread boost::thread_group threads; - threads.create_thread(bind(&SecurityFixture::server, this, static_cast(si))); + (void)threads.create_thread(bind(&SecurityFixture::server, this, static_cast(si))); mCVar.wait(lock); // wait for listen() to succeed lock.unlock(); - threads.create_thread(bind(&SecurityFixture::client, this, static_cast(ci))); + (void)threads.create_thread(bind(&SecurityFixture::client, this, static_cast(ci))); threads.join_all(); BOOST_CHECK_MESSAGE(mConnected == matrix[ci][si], -- cgit v1.2.1