summaryrefslogtreecommitdiff
path: root/source3/libsmb
Commit message (Collapse)AuthorAgeFilesLines
* s3: libsmb: Ensure return from net_share_enum_rpc() sets cli->raw_status on ↵Jeremy Allison2019-11-051-11/+22
| | | | | | | | | | | | | | | error. Convert net_share_enum_rpc() to return an NTSTATUS and ensure the status is set correctly on error so SMBC_errno() can return it. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14176 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Tue Nov 5 12:36:48 UTC 2019 on sn-devel-184
* s3:smbclient added ABI signature filePuran Chand2019-10-301-0/+188
| | | | | | | | Signed-off-by: Puran Chand <pchand@vmware.com> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Wed Oct 30 22:18:15 UTC 2019 on sn-devel-184
* s3: libsmb: Added new API smbc_readdirplus2()Jeremy Allison2019-10-305-1/+118
| | | | | | | | | | | | Returns the same as smbc_readdirplus() but also can return a struct stat if passed in by the caller. struct stat is synthesized from the data returned by the SMB server. Signed-off-by: Puran Chand <pchand@vmware.com> Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3: libsmb: Add missing ino field to internal struct smbc_dirplus_list.Jeremy Allison2019-10-301-0/+1
| | | | | | | | | | | | This should have been added to struct libsmb_file_info, but this is user-visible so I don't want to change this now. Adding it to the containing struct allows us to synthesise a struct stat to return from smbc_readdirplus2() to return all the info from the server to callers. Signed-off-by: Puran Chand <pchand@vmware.com> Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3: libsmb: Move setting all struct stat fields into setup_stat().Jeremy Allison2019-10-301-13/+28
| | | | | | | | That way we only have one place where a struct stat is synthesised for libsmbclient callers. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3: libsmb: Move setting st->st_ino into setup_stat.Jeremy Allison2019-10-301-8/+7
| | | | | | Signed-off-by: Puran Chand <pchand@vmware.com> Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3: libsmb: Change generate_inode()/setup_stat() to modern coding standards.Jeremy Allison2019-10-301-26/+22
| | | | | | | | | | | | Change setup_stat() to be void. It doesn't return anything. Export so it can be used by upcoming smbc_readdirplus2() call. Remove unused SMBCCTX *context parameters. Remove unused talloc_stackframe(). Signed-off-by: Puran Chand <pchand@vmware.com> Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3: libsmb: Ensure we don't call cli_RNetShareEnum() on an SMB1 connection.Jeremy Allison2019-10-301-1/+6
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14174 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* CVE-2019-10218 - s3: libsmb: Protect SMB2 client code from evil server ↵Jeremy Allison2019-10-291-0/+7
| | | | | | | | | | returned names. Disconnect with NT_STATUS_INVALID_NETWORK_RESPONSE if so. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14071 Signed-off-by: Jeremy Allison <jra@samba.org>
* CVE-2019-10218 - s3: libsmb: Protect SMB1 client code from evil server ↵Jeremy Allison2019-10-292-0/+78
| | | | | | | | | | returned names. Disconnect with NT_STATUS_INVALID_NETWORK_RESPONSE if so. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14071 Signed-off-by: Jeremy Allison <jra@samba.org>
* s3/libsmb: clang: Fix 'the left operand of '-' is a garbage value'Noel Power2019-10-221-2/+2
| | | | | | | | | | | | | Fixes: source3/libsmb/clifile.c:360:19: warning: The left operand of '-' is a garbage value <--[clang] if (data[num_data-1] != '\0') { ~~~~~~~~^ Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Ralph Boehme <slow@samba.org> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Tue Oct 22 18:48:43 UTC 2019 on sn-devel-184
* s3/libsmb: clang: Fix 'Assigned value is garbage or undefined'Noel Power2019-10-221-1/+1
| | | | | | | | | | | Fixes: source3/libsmb/clirap.c:1490:9: warning: Assigned value is garbage or undefined <--[clang] *mode = attr; ^ ~~~~ Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3/libsmb: clang: Fix 'Value stored to 'p' is never read'Noel Power2019-10-221-1/+0
| | | | | | | | | | | Fixes: source3/libsmb/clirap.c:145:3: warning: Value stored to 'p' is never read <--[clang] p = rdata; ^ ~~~~~ Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3/libsmb: clang: Fix 'Assigned value is garbage or undefined'Noel Power2019-10-221-2/+2
| | | | | | | | | | | | Fixes: source3/libsmb/smbsock_connect.c:786:13: warning: Assigned value is garbage or undefined <--[clang] state->fd = fd; ^ ~~ 1 warning generated. Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3/libsmb: clang: Fix 'Value stored to 'create_options' is never read'Noel Power2019-10-221-1/+1
| | | | | | | | | | | | | It looks like the create_options are accumulated as the depending on the failure reasons returned for cli_smb2_create_fnum (except for when a directory is encountered) this looks like a mistake Fixes: source3/libsmb/cli_smb2_fnum.c:1870:3: warning: Value stored to 'create_options' is never read <--[clang] create_options |= FILE_DIRECTORY_FILE; ^ Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3/libsmb: clang: Fix 'Dereference of undefined pointer value'Noel Power2019-10-221-1/+9
| | | | | | | | | | | | Fixes: source3/libsmb/clidfs.c:350:3: warning: Dereference of undefined pointer value <--[clang] DLIST_ADD_END(referring_cli, cli); ^ 1 warning generated. Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3/libsmd: clang: Fix some uninitialized value errorsNoel Power2019-10-221-2/+2
| | | | | | | | | | | | | | | Fixes: source3/libsmb/clilist.c:534:14: warning: 1st function call argument is an uninitialized value <--[clang] num_finfo = talloc_array_length(finfo); ^ source3/libsmb/clilist.c:1007:13: warning: The right operand of '<' is a garbage value <--[clang] for (i=0; i<num_finfo; i++) { ^~~~~~~~~~ 2 warnings generated. Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3/libsmb: clang: Fix 'Value stored to 'p' is never read'Noel Power2019-10-221-1/+0
| | | | | | | | | | | | Fixes: source3/libsmb/climessage.c:73:2: warning: Value stored to 'p' is never read <--[clang] p += hlen; ^ ~~~~ 1 warning generated. Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: libsmb: Ensure SMB1 cli_qpathinfo2() doesn't return an inode number.Jeremy Allison2019-10-181-1/+9
| | | | | | | | | | | | | The info level it uses doesn't return that, previously we were using the field that is returned as the EA size as the inode number (which is usually zero, so the code in libsmbclient would then synthesize an inode number from a hash of the pathname, which is all it can do for SMB1). BUG: https://bugzilla.samba.org/show_bug.cgi?id=14161 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3:libsmb: Link libsmb against pthreadIsaac Boukris2019-10-161-0/+1
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140 Signed-off-by: Isaac Boukris <iboukris@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org>
* s3:libsmb: Do not check the SPNEGO neg token for KRB5Andreas Schneider2019-10-121-50/+0
| | | | | | | | | | | | | The list is not protected and this could be a downgrade attack. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106 Pair-Programmed-With: Isaac Boukris <iboukris@redhat.com> Reviewed-by: Andreas Schneider <asn@samba.org> Signed-off-by: Andreas Schneider <asn@samba.org> Signed-off-by: Isaac Boukris <iboukris@redhat.com> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:libnet: Require sealed LDAP SASL connections for joiningAndreas Schneider2019-10-091-1/+1
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org>
* s3/libsmb: clang: Fix 'Value stored during its initialization is never read'Noel Power2019-09-301-1/+1
| | | | | | | | | | Fixes: source3/libsmb/cliconnect.c:1877:11: warning: Value stored to 'status' during its initialization is never read <--[clang] NTSTATUS status = NT_STATUS_NO_MEMORY; Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3/libsmb: clang: Fix 'warning: Value stored to 'p' is never read'Noel Power2019-09-261-1/+0
| | | | | | | | | | | | | | Fixes: source3/libsmb/cliconnect.c:649:2: warning: Value stored to 'p' is never read <--[clang] p += ret; ^ ~~~ Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Sep 26 19:59:24 UTC 2019 on sn-devel-184
* s3/libsmb: clang: value stored to 'idx_current' is never readNoel Power2019-09-261-1/+0
| | | | | | | | | | | Fixes: source3/libsmb/trusts_util.c:602:2: warning: Value stored to 'idx_current' is never read <--[clang] idx_current = idx; ^ ~~~ Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3/libsmb: clang: Fix 'Value stored during its initialization is never read'Noel Power2019-09-261-2/+2
| | | | | | | | | | | | | | | Fixes: source3/libsmb/dsgetdcname.c:1012:11: warning: Value stored to 'status' during its initialization is never read <--[clang] NTSTATUS status = NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND; ^~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ source3/libsmb/dsgetdcname.c:1099:11: warning: Value stored to 'status' during its initialization is never read <--[clang] NTSTATUS status = NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND; ^~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3:libsmb: let cli_session_creds_prepare_krb5() update the canonicalized ↵Stefan Metzmacher2019-09-241-5/+34
| | | | | | | | | principal to cli_credentials BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s3:libsmb: avoid wrong debug message in cli_session_creds_prepare_krb5()Stefan Metzmacher2019-09-241-0/+2
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s3: libsmbclient: Fix smbc_lseekdir() to work with smbc_readdirplus().Jeremy Allison2019-09-031-26/+43
| | | | | | | | | | If returning files the dir_list and the dirplus_list have exactly the same entries, we just need to keep the next pointers in sync on seek. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14094 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s3: libsmbclient: Ensure SMBC_getdents_ctx() also updates the readdirplus ↵Jeremy Allison2019-09-031-0/+11
| | | | | | | | | | | | | | | pointers. If we are returning file entries, we have a duplicate list in dirplus. Update dirplus_next also so readdir and readdirplus are kept in sync. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14094 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s3: libsmbclient: Ensure SMBC_readdirplus_ctx() also updates the readdir ↵Jeremy Allison2019-09-031-0/+11
| | | | | | | | | | | | | | | pointers. If we are returning file entries, we have a duplicate list in dir_list. Update dir_next also so readdir and readdirplus are kept in sync. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14094 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* s3: libsmbclient: Ensure SMBC_readdir_ctx() also updates the readdirplus ↵Jeremy Allison2019-09-031-0/+11
| | | | | | | | | | | | | | | pointers. If we are returning file entries, we have a duplicate list in dirplus. Update dirplus_next also so readdir and readdirplus are kept in sync. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14094 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* Spelling fixes s/wont /won't /Mathieu Parent2019-09-011-1/+1
| | | | | | Signed-off-by: Mathieu Parent <math.parent@gmail.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
* Spelling fixes s/hierachy/hierarchy/Mathieu Parent2019-09-011-1/+1
| | | | | | Signed-off-by: Mathieu Parent <math.parent@gmail.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
* s3/libsmb: clang: Fix 'Value stored during initialization is never read'Noel Power2019-08-281-3/+1
| | | | | | | | | | | | | | | | | | Fixes: source3/libsmb/cliquota.c:340:11: warning: Value stored to 'status' during its initialization is never read <--[clang] NTSTATUS status = NT_STATUS_UNSUCCESSFUL; ^~~~~~ ~~~~~~~~~~~~~~~~~~~~~~ source3/libsmb/cliquota.c:357:4: warning: Value stored to 'status' is never read <--[clang] status = NT_STATUS_OK; ^ ~~~~~~~~~~~~ 2 warnings generated. Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz> Autobuild-User(master): Gary Lockyer <gary@samba.org> Autobuild-Date(master): Wed Aug 28 03:06:42 UTC 2019 on sn-devel-184
* s3/libsmb: clang: Fix 'Value stored to 'status' is never read'Noel Power2019-08-281-1/+1
| | | | | | | | | | | | | | | Fixes: source3/libsmb/cliquota.c:340:11: warning: Value stored to 'status' during its initialization is never read <--[clang] NTSTATUS status = NT_STATUS_UNSUCCESSFUL; ^~~~~~ ~~~~~~~~~~~~~~~~~~~~~~ /home/samba/samba/source3/libsmb/cliquota.c:357:4: warning: Value stored to 'status' is never read <--[clang] status = NT_STATUS_OK; ^ ~~~~~~~~~~~~ 2 warnings generated. Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
* s3/libsmb: clang: Fix 'warning: Value stored to 'status' is never read'Noel Power2019-08-281-6/+6
| | | | | | | | | | | Fixes: source3/libsmb/namequery.c:2938:2: warning: Value stored to 'status' is never read <--[clang] status = NT_STATUS_OK; ^ ~~~~~~~~~~~~ Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
* s3/libsmb: clang: Fix 2nd function call argument is an uninitialized valueNoel Power2019-08-281-2/+2
| | | | | | | | | | | source3/libsmb/namequery.c:2719:11: warning: 2nd function call argument is an uninitialized value <--[clang] if (!convert_ss2service(return_iplist, ^ source3/libsmb/namequery.c:2733:10: warning: 2nd function call argument is an uninitialized value <--[clang] if (!convert_ss2service(return_iplist, ^ Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
* s3/libsmb: clang: Fix Value set during its initialization is never readNoel Power2019-08-281-1/+1
| | | | | | | | | Fixes: source3/libsmb/namequery.c:2584:11: warning: Value stored to 'status' during its initialization is never read <--[clang] NTSTATUS status = NT_STATUS_UNSUCCESSFUL; Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
* s3/libsmb: clang: Fix: The right operand of '<' is a garbage valueNoel Power2019-08-281-1/+1
| | | | | | | | | | | Fixes: source3/libsmb/namequery.c:977:12: warning: The right operand of '<' is a garbage value <--[clang] for (i=0;i<count;i++) { ^~~~~~ Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
* s3/libsmb: clang: Fix value stored to 'offset' is never readNoel Power2019-08-281-3/+2
| | | | | | | | | | | | Fixes: source3/libsmb/nmblib.c:479:2: warning: Value stored to 'offset' is never read <--[clang] offset += 10+rec->rdlength; ^ ~~~~~~~~~~~~~~~~ 1 warning generated. Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
* s3/libsmb: clang: Fix 'warning: Assigned value is garbage or undefined 'Noel Power2019-08-281-1/+1
| | | | | | | | | | | | | | | | | | Fixes: source3/libsmb/clireadwrite.c:1259:17: warning: Assigned value is garbage or undefined <--[clang] state->written += written; ^ ~~~~~~~ source3/libsmb/clireadwrite.c:1722:14: warning: The left operand of '>' is a garbage value <--[clang] if (written > expected) { ~~~~~~~ ^ Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz> Autobuild-User(master): Gary Lockyer <gary@samba.org> Autobuild-Date(master): Wed Aug 28 00:22:49 UTC 2019 on sn-devel-184
* s3/libsmb: clang: Fix 'Assigned value is garbage or undefined'Noel Power2019-08-271-1/+1
| | | | | | | | | | | Fixes: source3/libsmb/clireadwrite.c:851:10: warning: Assigned value is garbage or undefined <--[clang] *nread = ret; ^ Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
* s3/libsmb: clang: Fix '2nd func call argument is uninitalized value'Noel Power2019-08-271-2/+2
| | | | | | | | | | | Fixes: source3/libsmb/clireadwrite.c:805:2: warning: 2nd function call argument is an uninitialized value <--[clang] memcpy(state->buf, buf, received); ^ ~~~ Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
* s3/libsmb: clang: Fix 'The left operand of '>' or '<' is a garbage valueNoel Power2019-08-271-1/+1
| | | | | | | | | | | | | | Fixes: source3/libsmb/clireadwrite.c:601:15: warning: The left operand of '>' is a garbage value <--[clang] if (received > expected) { source3/libsmb/clireadwrite.c:799:16: warning: The left operand of '<' is a garbage value <--[clang] if ((received < 0) || (received > state->buflen)) { ~~~~~~~~ ^ Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
* s3/libsmb: clang: Fix 'Value stored to 'p' is never read' warningNoel Power2019-08-271-4/+3
| | | | | | | | | | | | | | | | | | | | | Fixes: source3/libsmb/clirap2.c:1197:4: warning: Value stored to 'p' is never read <--[clang] p += rap_getstringp(frame, ^ ~~~~~~~~~~~~~~~~~~~~~ source3/libsmb/clirap2.c:1525:5: warning: Value stored to 'p' is never read <--[clang] p += rap_getstring(frame, ^ ~~~~~~~~~~~~~~~~~~~~ source3/libsmb/clirap2.c:2358:3: warning: Value stored to 'p' is never read <--[clang] p += WORDSIZE; /* skip rsize */ ^ ~~~~~~~~ source3/libsmb/clirap2.c:2380:3: warning: Value stored to 'p' is never read <--[clang] p += rap_getstringp(frame, ^ ~~~~~~~~~~~~~~~~~~~~~ 4 warnings generated. Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
* s3/libsmb: clang: Fix 'Value stored to 'ea_size' is never read'Noel Power2019-08-271-1/+0
| | | | | | | | | | Fixes: source3/libsmb/clifile.c:5290:2: warning: Value stored to 'ea_size' is never read <--[clang] ea_size = (size_t)IVAL(rdata,0); ^ ~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
* s3/libsmb: clang: Fix 'Assigned value is garbage or undefined'Noel Power2019-08-271-1/+1
| | | | | | | | | | | | | | | | Fixes: source3/libsmb/clifile.c:4898:10: warning: Assigned value is garbage or undefined <--[clang] *bsize = (uint64_t)old_bsize; ^ ~~~~~~~~~~~~~~~~~~~ source3/libsmb/clifile.c:4901:10: warning: Assigned value is garbage or undefined <--[clang] *total = (uint64_t)old_total; ^ ~~~~~~~~~~~~~~~~~~~ source3/libsmb/clifile.c:4904:10: warning: Assigned value is garbage or undefined <--[clang] *avail = (uint64_t)old_avail; Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
* s3/libsmb: clang: Fix 'The left operand of '&' is a garbage value'Noel Power2019-08-271-1/+1
| | | | | | | | | | | Fixes: source3/libsmb/clifile.c:3108:26: warning: The left operand of '&' is a garbage value <--[clang] (cr.file_attributes & FILE_ATTRIBUTE_DIRECTORY)) ~~~~~~~~~~~~~~~~~~ ^ Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
* s3/libsmb: clang: Fix 'The left operand of '!=' is a garbage value'Noel Power2019-08-271-1/+1
| | | | | | | | | | | Fixes: source3/libsmb/clifile.c:789:15: warning: The left operand of '!=' is a garbage value <--[clang] if (num_data != 100) { ~~~~~~~~ ^ Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
View Lorry Controller Status