diff options
| author | Noel Power <noel.power@suse.com> | 2019-08-09 16:06:20 +0100 |
|---|---|---|
| committer | Gary Lockyer <gary@samba.org> | 2019-08-28 03:06:42 +0000 |
| commit | 0be320393b85003f65d74e4e6a1b867a8d21eb1c (patch) | |
| tree | 8ff7bd8cda84ebc6a89ec3fca2adb820e50ea57c /source3/libsmb | |
| parent | 0c91634ebe4065bfb66c5cf575659aa1150fc2fb (diff) | |
| download | samba-0be320393b85003f65d74e4e6a1b867a8d21eb1c.tar.gz | |
s3/libsmb: clang: Fix 'Value stored during initialization is never read'
Fixes:
source3/libsmb/cliquota.c:340:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
^~~~~~ ~~~~~~~~~~~~~~~~~~~~~~
source3/libsmb/cliquota.c:357:4: warning: Value stored to 'status' is never read <--[clang]
status = NT_STATUS_OK;
^ ~~~~~~~~~~~~
2 warnings generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Wed Aug 28 03:06:42 UTC 2019 on sn-devel-184
Diffstat (limited to 'source3/libsmb')
| -rw-r--r-- | source3/libsmb/cliquota.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/source3/libsmb/cliquota.c b/source3/libsmb/cliquota.c index 06290afb3ec..45cd3280045 100644 --- a/source3/libsmb/cliquota.c +++ b/source3/libsmb/cliquota.c @@ -353,9 +353,7 @@ cli_set_user_quota(struct cli_state *cli, int quota_fnum, SMB_NTQUOTA_LIST *qtl) * smb1 doesn't send NT_STATUS_NO_MORE_ENTRIES so swallow * this status. */ - if (NT_STATUS_EQUAL(status, NT_STATUS_NO_MORE_ENTRIES)) { - status = NT_STATUS_OK; - } else { + if (!NT_STATUS_EQUAL(status, NT_STATUS_NO_MORE_ENTRIES)) { goto cleanup; } } |