diff options
| author | Noel Power <noel.power@suse.com> | 2019-08-13 15:36:56 +0100 |
|---|---|---|
| committer | Ralph Boehme <slow@samba.org> | 2019-10-22 17:28:27 +0000 |
| commit | 4995a0e7e05c4affc9f1f7992cef54e57d9efdc0 (patch) | |
| tree | 17834264dbd3c885f16579374c0afce0c1e4929c /source3/libsmb | |
| parent | 25a256bedf2992771b6ea1263fb5e730b27a53dc (diff) | |
| download | samba-4995a0e7e05c4affc9f1f7992cef54e57d9efdc0.tar.gz | |
s3/libsmb: clang: Fix 'Value stored to 'create_options' is never read'
It looks like the create_options are accumulated as the depending on the
failure reasons returned for cli_smb2_create_fnum (except for when a
directory is encountered) this looks like a mistake
Fixes:
source3/libsmb/cli_smb2_fnum.c:1870:3: warning: Value stored to 'create_options' is never read <--[clang]
create_options |= FILE_DIRECTORY_FILE;
^
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Diffstat (limited to 'source3/libsmb')
| -rw-r--r-- | source3/libsmb/cli_smb2_fnum.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/libsmb/cli_smb2_fnum.c b/source3/libsmb/cli_smb2_fnum.c index 535beaab841..15f1420dd8f 100644 --- a/source3/libsmb/cli_smb2_fnum.c +++ b/source3/libsmb/cli_smb2_fnum.c @@ -1876,7 +1876,7 @@ static NTSTATUS get_fnum_from_path(struct cli_state *cli, FILE_ATTRIBUTE_DIRECTORY, /* file attributes */ FILE_SHARE_READ|FILE_SHARE_WRITE|FILE_SHARE_DELETE, /* share_access */ FILE_OPEN, /* create_disposition */ - FILE_DIRECTORY_FILE, /* create_options */ + create_options, /* create_options */ NULL, pfnum, NULL, |