summaryrefslogtreecommitdiff
path: root/nsswitch
Commit message (Collapse)AuthorAgeFilesLines
* testprogs: Have testfail() return 0 on successJoseph Sutton2023-04-121-4/+5
| | | | | | This is more consistent with the other testing functions. Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andreas Schneider <asn@samba.org>
* nsswitch:tests: Remove unused functionsJoseph Sutton2023-04-121-34/+0
| | | | Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andreas Schneider <asn@samba.org>
* testprogs: Make testit_expect_failure() return 0 on successJoseph Sutton2023-04-121-2/+2
| | | | | | | | | This is the behaviour that most existing callers expect, but the function actually returns a non-zero status code in that case. Adjust all callers expecting the opposite behaviour to match. Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andreas Schneider <asn@samba.org>
* nsswitch:tests: Use configuration variable passed to test_rfc2307_mapping.shAndreas Schneider2023-04-061-7/+10
| | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=15336 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* test: Add a test for "deny ous"Volker Lendecke2023-03-291-0/+34
| | | | | | | | | Not a comprehensive test for all possible combinations, but it shows the basic functionality, and it found a bug in the initial implementation :-) Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* tests: Slightly simplify test_idmap_ad.shVolker Lendecke2023-03-291-20/+0
| | | | | | | ldbmodify can change multiple objects in one run Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* nsswitch: Fix CID 1518966 Resource leaks (RESOURCE_LEAK)Joseph Sutton2023-03-031-0/+2
| | | | | Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* nsswitch: Fix getting data out of pam_get_data()Andreas Schneider2023-02-061-3/+2
| | | | | | | | | | | nsswitch/pam_winbind.c:3360:24: error: cast from 'time_t **' (aka 'long **') to 'const void **' must have all intermediate pointers const qualified to be safe [-Werror,-Wcast-qual] (const void **)&pwdlastset_update); ^ Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* spelling fixes for 4.18 (errror implemenation proces Controler)Michael Tokarev2023-01-261-1/+1
| | | | | | | | | | | | | | One of changes is somewhat interesting, it is "tfork waiter proces" process title in tfork.c. I wonder why no one noticed this before. There's another similar process title in there, "tfork waiter process(%d)". Hopefully no one does grep for "proces$" (and there's no reason to). Signed-off-by: Michael Tokarev <mjt@tls.msk.ru> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Rowland Penny <rpenny@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Jan 26 20:46:11 UTC 2023 on atb-devel-224
* nsswitch: avoid calling pthread_getspecific() on an uninitialized keyRalph Boehme2023-01-061-5/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Found by ASAN: $ bin/stress-nss-libwbclient ... ==1639426==ERROR: AddressSanitizer: unknown-crash on address 0x7f3907d85000 at pc 0x7f3907d649fb bp 0x7ffc6545f5b0 sp 0x7ffc6545f5a8 READ of size 4 at 0x7f3907d85000 thread T0 #0 0x7f3907d649fa in winbind_close_sock ../../nsswitch/wb_common.c:220 #1 0x7f3907d65866 in winbind_destructor ../../nsswitch/wb_common.c:246 #2 0x7f3907da5d3d in _dl_fini /usr/src/debug/glibc-2.35-20.fc36.x86_64/elf/dl-fini.c:142 #3 0x7f3907241044 in __run_exit_handlers (/lib64/libc.so.6+0x41044) #4 0x7f39072411bf in exit (/lib64/libc.so.6+0x411bf) #5 0x7f3907229516 in __libc_start_call_main (/lib64/libc.so.6+0x29516) #6 0x7f39072295c8 in __libc_start_main_impl (/lib64/libc.so.6+0x295c8) #7 0x56236a2042b4 in _start (/data/git/samba/scratch3/bin/default/nsswitch/stress-nss-libwbclient+0x22b4) Address 0x7f3907d85000 is a wild pointer inside of access range of size 0x000000000004. SUMMARY: AddressSanitizer: unknown-crash ../../nsswitch/wb_common.c:220 in winbind_close_sock The pthread key in wb_global_ctx.key is only initialized if wb_thread_ctx_initialize() is called via get_wb_global_ctx() -> get_wb_thread_ctx(). Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Fri Jan 6 15:04:46 UTC 2023 on sn-devel-184
* nsswitch: remove winbind_nss_mutexRalph Boehme2023-01-051-89/+0
| | | | | | | | | | We're now thread-safe by using TLS, so the global lock isn't needed anymore. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Thu Jan 5 12:34:35 UTC 2023 on sn-devel-184
* nsswitch: leverage TLS if available in favour over global lockingRalph Boehme2023-01-052-22/+109
| | | | | | | | | | | | | | | | The global locking can lead to deadlocks when using nscd: when processing the first request in winbind, when we know we call into code that will recurse into winbind we call winbind_off() which sets an environment variable which is later checked here in the nsswitch module. But with nscd in the stack, we don't see the env variable in nsswitch, so when we try to acquire the global lock again, it is already locked and we deadlock. By using a thread specific winbindd_context, plus a few other thread local global variables, we don't need a global lock anymore. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* nsswitch: prepare for removing global locking by using TLSRalph Boehme2023-01-052-18/+18
| | | | | | | Switch to using TLS for all global variables. No change in behaviour. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* nsswitch/stress-nss-libwbclient: also test after forkRalph Boehme2023-01-051-0/+152
| | | | | Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* nsswitch:tests: Use system_or_builddir_binary() for test_rfc2307_mappingAndreas Schneider2022-12-231-6/+3
| | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* wbinfo: Add --change-secret-at=dcnameRalph Boehme2022-12-211-1/+52
| | | | | | | Add WHATSNEW.txt entry and update wbinfo man page. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* libwbclient: add wbc[Ctx]ChangeTrustCredentialsAt()Ralph Boehme2022-12-214-4/+197
| | | | | Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* nsswitch: Align integer typesVolker Lendecke2022-12-121-1/+2
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* Fix memleak in _nss_winbind_initgroups_dynSushmita Bhattacharya2022-12-091-0/+1
| | | | | | | | Free the response at the end of _nss_winbind_initgroups_dyn Signed-off-by: Sushmita Bhattacharya <sushmita.bhattacharya@oracle.com> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* nsswitch:tests: Use ldb(modify|search) from the systemAndreas Schneider2022-12-051-2/+9
| | | | | | | | | | If Samba is built against the system libldb, use the system tools. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Mon Dec 5 09:36:40 UTC 2022 on sn-devel-184
* pam_winbind: Fix a memleakVolker Lendecke2022-11-221-1/+4
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* nsswitch: Fix uninitialized memory when allocating pwdlastset_prelimNoel Power2022-11-161-1/+1
| | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=15224 Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Nov 16 19:29:21 UTC 2022 on sn-devel-184
* nsswitch: Fix pam_set_data()/pam_get_data() to use pointers to a time_t, not ↵Jeremy Allison2022-11-161-7/+17
| | | | | | | | | | | | try and embedd it directly. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15224 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Noel Power <npower@samba.org> Autobuild-User(master): Noel Power <npower@samba.org> Autobuild-Date(master): Wed Nov 16 15:09:45 UTC 2022 on sn-devel-184
* nsswitch:libwbclient - fix leak in wbcCtxPingDc2Andrew Walker2022-09-061-0/+1
| | | | | | | | | | | | | Memory allocated for response is never freed. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15164 Signed-off-by: Andrew Walker <awalker@ixsystems.com> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Christof Schmitt <cs@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Tue Sep 6 20:10:17 UTC 2022 on sn-devel-184
* nsswitch: Fix shellcheck errors in test_rfc2307_mapping.shAndreas Schneider2022-08-171-6/+12
| | | | | | | nsswitch/tests/test_rfc2307_mapping.sh:65:139: error: Double quote array expansions to avoid re-splitting elements. [SC2068] Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Pavel Filipenský <pfilipensky@samba.org>
* nsswitch/wins: Define NETDB_* for other libc'slistout2022-08-081-0/+8
| | | | | | | | | Define NETDB_SUCCESS and NETDB_INTERNAL if they are not defined. On libc's such as musl NETDB_INTERNAL and NETDB_SUCCESS are not defined. Signed-off-by: listout <brahmajit.xyz@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* s3:winbind: Convert InitConnection from struct based to NDR basedSamuel Cabrero2022-05-191-3/+1
| | | | | Signed-off-by: Samuel Cabrero <scabrero@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* winbind: send "debug traceid" from winbindd parent to childPavel Filipenský2022-05-101-1/+3
| | | | | | | | | | | | | Bumping WINBIND_INTERFACE_VERSION to 32 Pair-Programmed-With: Andreas Schneider <asn@samba.org> Signed-off-by: Pavel Filipenský <pfilipen@redhat.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Tue May 10 18:25:01 UTC 2022 on sn-devel-184
* selftest: Extend test_wbc_logon_user to test WBFLAG_PAM_UNIX_NAME flagSamuel Cabrero2022-04-081-0/+46
| | | | | | | | | Use the same function append_unix_username() uses to build the expected value as it depends on the server role. This requires linking winbindd-lib. Signed-off-by: Samuel Cabrero <scabrero@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* nsswitch: let test_wbinfo.sh also test wbinfo -a $USERNAME@$DOMAINStefan Metzmacher2022-03-101-0/+2
| | | | | | | | | | | | | | | | When winbindd forwards wbinfo -a via netrLogonSamLogon* to a remote DC work fine for upn names, e.g. administrator@DOMAIN. But it currently fails locally on a DC against the local sam. For the RODC only work because it forwards the request to an RWDC. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13879 BUG: https://bugzilla.samba.org/show_bug.cgi?id=15003 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* nsswitch: Reformat shell scriptsAndreas Schneider2022-02-2412-307/+310
| | | | | | shfmt -f nsswitch/ | xargs shfmt -w -p -i 0 -fn Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* pam_winbind: add new pwd_change_prompt option (defaults to off).Günther Deschner2021-12-162-2/+11
| | | | | | | | | | | | | | | | This change disables the prompt for the change of an expired password by default (using the PAM_RADIO_TYPE mechanism if present). BUG: https://bugzilla.samba.org/show_bug.cgi?id=8691 Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Dec 16 03:05:30 UTC 2021 on sn-devel-184
* nsswitch: reduce dependecies to private libraries and link static/builtin if ↵Stefan Metzmacher2021-11-302-63/+100
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | possible Over the last month I got more and more reports, that it's not possible to use a custom Samba version on systems with sssd being installed, which depends on some specific samba libraries installed in the system. One major problem is that the custom libnss_winbind.so.2 depends on the libreplace-samba4.so of the custom build and also injects an RPATH into the running process. When sssd uses any nss library call it will get this, when it then tries to load some of its plugins via dlopen(), e.g. ldd /usr/lib64/sssd/libsss_ad.so| grep samba libsamba-util.so.0 => /lib64/libsamba-util.so.0 libreplace-samba4.so => /usr/lib64/samba/libreplace-samba4.so libsamba-security-samba4.so => /usr/lib64/samba/libsamba-security-samba4.so libsamba-errors.so.1 => /lib64/libsamba-errors.so.1 libsamba-debug-samba4.so => /usr/lib64/samba/libsamba-debug-samba4.so libgenrand-samba4.so => /usr/lib64/samba/libgenrand-samba4.so libsocket-blocking-samba4.so => /usr/lib64/samba/libsocket-blocking-samba4.so libtime-basic-samba4.so => /usr/lib64/samba/libtime-basic-samba4.so libsys-rw-samba4.so => /usr/lib64/samba/libsys-rw-samba4.so libiov-buf-samba4.so => /usr/lib64/samba/libiov-buf-samba4.so When that loads dlopen() will fail as a soname libreplace-samba4.so is already loaded, but the symbol version within the other one don't match, as the contain the exact version, e.g. replace_dummy@@SAMBA_4.13.3. This is just an example and similar things can happen in all situations where we provide libraries, which are potentially injected into every process of the running system. These should only depend on libc.so and related basic system libraries in order to avoid the problem. We have the following libraries, which are in the that category: - libnss_winbind.so.2 - libnss_wins.so.2 - pam_winbind.so - winbind_krb5_locator.so - async_dns_krb5_locator.so The rules of library loading are really complex and symbol versioning is not enough to solve it, only the combination of unique soname and unique symbol version suffix seem to solve the problem, but injecting an RPATH is still a problem. In order to solve the problem I experimented with adding SAMBA_SUBSYSTEM() definitions with 'hide_symbols=True' in order to do some static linking of selected components, e.g. bld.SAMBA_SUBSYSTEM('replace-hidden', source=REPLACE_SOURCE, group='base_libraries', hide_symbols=True, deps='dl attr' + extra_libs) It's relatively simple to get to the point where the following are completely static: - libnss_winbind.so.2 - libnss_wins.so.2 - pam_winbind.so - winbind_krb5_locator.so But 'async_dns_krb5_locator.so' links in almost everything! It seems we install the krb5 plugins into our own $MODULESDIR/krb5/, so it may not be so critical, as long it's the admin who created the desired symlinks into the location the kerberos libraries search for plugins. Note the at least the locator plugins are always loaded without any configuration, every .so in a special path are loaded with dlopen(). This is done by every application using kerberos, so we load a lot of samba libraries into them. Packagers should not put async_dns_krb5_locator.so (nor a symlink) into the path that's reachable by libkrb5.so. As a longterm solution we may want to change async_dns_krb5_locator.so to use a helper process with posix_spawn() instead of doing everything within the process. Note I added hiden_symbols=True to the nss modules for Linux and FreeBSD only, because these are the only platforms I'm able to test on. We most likely should do the same on other platforms, but some with access to the platform should provide a tested patch. In order to avoid manual definitions of SAMBA_SUBSYSTEMS() with '-hidden', I added the 'provide_builtin_linking=True' option, as the logic is very similar to what we already have with the '--builtin-libraries=BUILTIN_LIBRARIES' configure option. SAMBA_PLUGIN() is used in order to use SAMBA_LIBRARY() in order to make it more strict that these plugins can't be used as normal depedency by other subsystems and libraries. While being there it was easy enough to make libwbclient.so also standalone without dependecies to other samba libraries. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14780 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* nsswitch/libwbclient: explicitly mark all wbc* symbols as _PUBLIC_Stefan Metzmacher2021-11-308-0/+134
| | | | | | | | | | | | | | | Some private functions from wbclient_internal.h already leaked into the ABI. With hide_symbols=True we make sure this doesn't happen again. Having wbcRequestResponse[Priv]() as part of the ABI helps us in order to hide winbindd_[priv_]request_response() soon. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14780 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* nsswitch: explicitly mark nss_module_register() _PUBLIC_ on FreeBSDStefan Metzmacher2021-11-302-6/+6
| | | | | | | | | | | This is the only symbol which is used via dlopen()/dlsym() and needs to be exported, in future we'll do hide all other symbols. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14780 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* nsswitch: explicitly mark NSS_STATUS _nss_winbind_* symbols as _PUBLIC_ on LinuxStefan Metzmacher2021-11-304-0/+27
| | | | | | | | | | | | | | The symbols which are used via dlopen()/dlsym() need to be exported, in future we'll do hide all other symbols. On other platforms, which are implemented as wrappers above the Linux implementation, we mark the symbols as _PRIVATE_ BUG: https://bugzilla.samba.org/show_bug.cgi?id=14780 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* nsswitch: explicitly mark PAM_EXTERN pam_sm_* symbols as _PUBLIC_Stefan Metzmacher2021-11-301-6/+6
| | | | | | | | | | | The symbols which are used via dlopen()/dlsym() need to be exported, in future we'll do hide all other symbols. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14780 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* nsswitch: explicitly mark magic krb5 plugin symbols as _PUBLIC_Stefan Metzmacher2021-11-303-4/+4
| | | | | | | | | | | The symbols which are used via dlopen()/dlsym() need to be exported, in future we'll do hide all other symbols. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14780 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* nsswitch/wbinfo: use wbcRequestResponse() instead of winbindd_request_response()Stefan Metzmacher2021-11-301-8/+13
| | | | | | | | | | | We should try to route everything through libwbclient.so, because we'll soon don't have a single library providing winbindd_request_response(). BUG: https://bugzilla.samba.org/show_bug.cgi?id=14780 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* nsswitch: move winbindd_free_response() as inline function to ↵Stefan Metzmacher2021-11-303-11/+10
| | | | | | | | | | | | winbind_struct_protocol.h nsswitch/wb_common.c will be made completely internal soon. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14780 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* libwbclient: fix strict-overflow warning in wbcSidToString()Stefan Metzmacher2021-11-301-1/+1
| | | | | | | | | | | | | | | | | | | | | ../../nsswitch/libwbclient/wbc_sid.c:83:5: error: assuming signed overflow does not occur when simplifying conditional [-Werror=strict-overflow] if (len+1 > sizeof(buf)) { ^ Even this would fail: ../../nsswitch/libwbclient/wbc_sid.c:83:5: error: assuming signed overflow does not occur when simplifying conditional [-Werror=strict-overflow] if (len >= sizeof(buf)) { ^ Note that this only seems to happen with gcc 7 and when -O3 and -fvisibility=hidden are used together. E.g. in the opensuse151-samba-o3 builds. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14780 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* CVE-2020-25717: nsswitch/nsstest.c: Lower 'non existent uid' to make room ↵Joseph Sutton2021-11-151-1/+1
| | | | | | | | | | for new accounts BUG: https://bugzilla.samba.org/show_bug.cgi?id=14901 Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* nsswitch: ensure the attrlist_t array is large enough for a NULL sentinelRalph Boehme2021-07-121-1/+1
| | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14754 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Mon Jul 12 15:11:42 UTC 2021 on sn-devel-184
* nsswitch: Migrate wbinfo to new cmdline option parserAndreas Schneider2021-06-202-4/+11
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture: Migrate smbtorture to new cmdline option parserAndreas Schneider2021-06-161-19/+25
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* nsswitch: Fix a typoVolker Lendecke2021-06-041-1/+1
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* tests: Use --configfile instead of -sAndreas Schneider2021-04-281-1/+1
| | | | | | | | | | We should use long options in tests to make clear what we are trying to do. Also the -s short option will be removed for --configfile later. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* tests: Use ldbsearch '--scope instead of '-s'Andreas Schneider2021-04-281-2/+2
| | | | | | | | We should use long options in tests to make clear what we are trying to do. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* wbinfo: Allow SID for -RVolker Lendecke2021-04-011-10/+15
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* nsswitch pam_winbind: Fix clang compilation errorGary Lockyer2021-02-121-0/+7
| | | | | | | | | | | Fix clang compilation error: error: format string is not a string literal [-Werror,-Wformat-nonliteral] Signed-off-by: Gary Lockyer <gary@catalyst.net.nz> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri Feb 12 00:10:50 UTC 2021 on sn-devel-184
View Lorry Controller Status