summaryrefslogtreecommitdiff
path: root/nsswitch
diff options
context:
space:
mode:
authorAndreas Schneider <asn@samba.org>2022-02-22 17:58:47 +0100
committerPavel Filipensky <pfilipensky@samba.org>2022-08-17 10:08:35 +0000
commit72f16b635445025a9b523974ba08c753ea78ed58 (patch)
tree135be95db4cd4bbf8be1e7fa4452523c162199ff /nsswitch
parentc3823ff371fe5c605ddaa61a3c76bc233d5f1501 (diff)
downloadsamba-72f16b635445025a9b523974ba08c753ea78ed58.tar.gz
nsswitch: Fix shellcheck errors in test_rfc2307_mapping.sh
nsswitch/tests/test_rfc2307_mapping.sh:65:139: error: Double quote array expansions to avoid re-splitting elements. [SC2068] Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Pavel Filipenský <pfilipensky@samba.org>
Diffstat (limited to 'nsswitch')
-rwxr-xr-xnsswitch/tests/test_rfc2307_mapping.sh18
1 files changed, 12 insertions, 6 deletions
diff --git a/nsswitch/tests/test_rfc2307_mapping.sh b/nsswitch/tests/test_rfc2307_mapping.sh
index 8cd2e5dc57e..d6d39a10b68 100755
--- a/nsswitch/tests/test_rfc2307_mapping.sh
+++ b/nsswitch/tests/test_rfc2307_mapping.sh
@@ -63,10 +63,12 @@ knownfail()
}
# Create new testing account
-testit "user add" $PYTHON $samba_tool user create --given-name="rfc2307" --surname="Tester" --initial="UT" rfc2307_test_user testp@ssw0Rd $@
+testit "user add" $PYTHON $samba_tool user create --given-name="rfc2307" \
+ --surname="Tester" --initial="UT" rfc2307_test_user testp@ssw0Rd "$@"
#test creation of six different groups
-testit "group add" $PYTHON $samba_tool group add $CONFIG --group-scope='Domain' --group-type='Security' rfc2307_test_group $@
+testit "group add" $PYTHON $samba_tool group add $CONFIG \
+ --group-scope='Domain' --group-type='Security' rfc2307_test_group "$@"
# Create new testing group
@@ -115,7 +117,9 @@ add: uidNumber
uidNumber: $UID_RFC2307TEST
EOF
-testit "modify gidNumber on group" $VALGRIND $ldbmodify -H ldap://$SERVER $PREFIX/tmpldbmodify -U$DOMAIN/$USERNAME%$PASSWORD $@ || failed=$(expr $failed + 1)
+testit "modify gidNumber on group" $VALGRIND $ldbmodify -H ldap://$SERVER \
+ $PREFIX/tmpldbmodify -U$DOMAIN/$USERNAME%$PASSWORD "$@" ||
+ failed=$(expr $failed + 1)
# Then add a gidNumber to the group record using ldbmodify
cat >$PREFIX/tmpldbmodify <<EOF
@@ -125,7 +129,9 @@ add: gidNumber
gidNumber: $GID_RFC2307TEST
EOF
-testit "modify gidNumber on group" $VALGRIND $ldbmodify -H ldap://$SERVER $PREFIX/tmpldbmodify -U$DOMAIN/$USERNAME%$PASSWORD $@ || failed=$(expr $failed + 1)
+testit "modify gidNumber on group" $VALGRIND $ldbmodify -H ldap://$SERVER \
+ $PREFIX/tmpldbmodify -U$DOMAIN/$USERNAME%$PASSWORD "$@" ||
+ failed=$(expr $failed + 1)
rm -f $PREFIX/tmpldbmodify
@@ -181,7 +187,7 @@ else
echo "success: wbinfo -Y check for sane mapping"
fi
-testit "group delete" $PYTHON $samba_tool group delete rfc2307_test_group $@
-testit "user delete" $PYTHON $samba_tool user delete rfc2307_test_user $@
+testit "group delete" $PYTHON $samba_tool group delete rfc2307_test_group "$@"
+testit "user delete" $PYTHON $samba_tool user delete rfc2307_test_user "$@"
exit $failed