diff options
| author | Volker Lendecke <vl@samba.org> | 2017-01-18 16:43:56 +0100 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2017-01-23 22:46:13 +0100 |
| commit | a4733c7fde1764dd42a24412c744794410e570ba (patch) | |
| tree | 2ab3b68fb22a6b7531d1f913615e0df7eb97bd45 /libcli/security | |
| parent | a3737ef6bca739952e72e9df7a96a5dd74eea2ac (diff) | |
| download | samba-a4733c7fde1764dd42a24412c744794410e570ba.tar.gz | |
libcli: Add an overflow check
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Diffstat (limited to 'libcli/security')
| -rw-r--r-- | libcli/security/util_sid.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/libcli/security/util_sid.c b/libcli/security/util_sid.c index 2ab47f2db2c..ac448765777 100644 --- a/libcli/security/util_sid.c +++ b/libcli/security/util_sid.c @@ -339,6 +339,10 @@ NTSTATUS add_sid_to_array(TALLOC_CTX *mem_ctx, const struct dom_sid *sid, { struct dom_sid *tmp; + if ((*num) == UINT32_MAX) { + return NT_STATUS_INTEGER_OVERFLOW; + } + tmp = talloc_realloc(mem_ctx, *sids, struct dom_sid, (*num)+1); if (tmp == NULL) { *num = 0; |