From a4733c7fde1764dd42a24412c744794410e570ba Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Wed, 18 Jan 2017 16:43:56 +0100 Subject: libcli: Add an overflow check Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison --- libcli/security/util_sid.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'libcli/security') diff --git a/libcli/security/util_sid.c b/libcli/security/util_sid.c index 2ab47f2db2c..ac448765777 100644 --- a/libcli/security/util_sid.c +++ b/libcli/security/util_sid.c @@ -339,6 +339,10 @@ NTSTATUS add_sid_to_array(TALLOC_CTX *mem_ctx, const struct dom_sid *sid, { struct dom_sid *tmp; + if ((*num) == UINT32_MAX) { + return NT_STATUS_INTEGER_OVERFLOW; + } + tmp = talloc_realloc(mem_ctx, *sids, struct dom_sid, (*num)+1); if (tmp == NULL) { *num = 0; -- cgit v1.2.1