summaryrefslogtreecommitdiff
path: root/ctdb/server
diff options
context:
space:
mode:
authorAmitay Isaacs <amitay@gmail.com>2018-06-06 15:47:13 +0200
committerAmitay Isaacs <amitay@samba.org>2019-10-24 04:06:43 +0000
commit680df07630a94b3e76edefe98ee0986e7e5e1f12 (patch)
tree174fb7973c1b89886fd8397dca82850922504141 /ctdb/server
parentc6427dddf5425b267d8c09e8df18653a48679646 (diff)
downloadsamba-680df07630a94b3e76edefe98ee0986e7e5e1f12.tar.gz
ctdb-daemon: Avoid memory leak when packet is deferred
Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
Diffstat (limited to 'ctdb/server')
-rw-r--r--ctdb/server/ctdb_server.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/ctdb/server/ctdb_server.c b/ctdb/server/ctdb_server.c
index 9724d1fe0a8..0d5451d62a8 100644
--- a/ctdb/server/ctdb_server.c
+++ b/ctdb/server/ctdb_server.c
@@ -375,8 +375,9 @@ static void ctdb_defer_packet(struct ctdb_context *ctdb, struct ctdb_req_header
return;
}
q->ctdb = ctdb;
- q->hdr = talloc_memdup(ctdb, hdr, hdr->length);
+ q->hdr = talloc_memdup(q, hdr, hdr->length);
if (q->hdr == NULL) {
+ talloc_free(q);
DEBUG(DEBUG_ERR,("Error copying deferred packet to self\n"));
return;
}