From 680df07630a94b3e76edefe98ee0986e7e5e1f12 Mon Sep 17 00:00:00 2001 From: Amitay Isaacs Date: Wed, 6 Jun 2018 15:47:13 +0200 Subject: ctdb-daemon: Avoid memory leak when packet is deferred Signed-off-by: Amitay Isaacs Reviewed-by: Martin Schwenke --- ctdb/server/ctdb_server.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'ctdb/server') diff --git a/ctdb/server/ctdb_server.c b/ctdb/server/ctdb_server.c index 9724d1fe0a8..0d5451d62a8 100644 --- a/ctdb/server/ctdb_server.c +++ b/ctdb/server/ctdb_server.c @@ -375,8 +375,9 @@ static void ctdb_defer_packet(struct ctdb_context *ctdb, struct ctdb_req_header return; } q->ctdb = ctdb; - q->hdr = talloc_memdup(ctdb, hdr, hdr->length); + q->hdr = talloc_memdup(q, hdr, hdr->length); if (q->hdr == NULL) { + talloc_free(q); DEBUG(DEBUG_ERR,("Error copying deferred packet to self\n")); return; } -- cgit v1.2.1