summaryrefslogtreecommitdiff
path: root/buildtools
diff options
context:
space:
mode:
authorBjörn Jacke <bj@sernet.de>2019-08-25 23:02:00 +0200
committerAndrew Bartlett <abartlet@samba.org>2019-09-21 19:33:25 +0000
commit8b43aabecbad2084169b229859bf5bfc9e2ddac0 (patch)
tree9db833e833364d660f3980019dd3fb42546138bf /buildtools
parent0141c82eedbe525169546f6d30488149c3a7ed7a (diff)
downloadsamba-8b43aabecbad2084169b229859bf5bfc9e2ddac0.tar.gz
samba_bundled.py avoid inefficient string concatenations
Signed-off-by: Bjoern Jacke <bjacke@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Diffstat (limited to 'buildtools')
-rw-r--r--buildtools/wafsamba/samba_bundled.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/buildtools/wafsamba/samba_bundled.py b/buildtools/wafsamba/samba_bundled.py
index 60ce7da7232..5f080dd8a7a 100644
--- a/buildtools/wafsamba/samba_bundled.py
+++ b/buildtools/wafsamba/samba_bundled.py
@@ -204,8 +204,8 @@ def CHECK_BUNDLED_SYSTEM(conf, libname, minversion='0.0.0',
version_checks = '%s >= %s' % (pkg, minversion)
if maxversion is not None:
version_checks += ' %s <= %s' % (pkg, maxversion)
- for v in version_blacklist:
- version_checks += ' %s != %s' % (pkg, v)
+
+ version_checks += "".join(' %s != %s' % (pkg, v) for v in version_blacklist)
# try pkgconfig first
if (conf.CHECK_CFG(package=pkg,