summaryrefslogtreecommitdiff
path: root/buildtools
diff options
context:
space:
mode:
authorBjörn Jacke <bj@sernet.de>2019-08-25 23:01:22 +0200
committerAndrew Bartlett <abartlet@samba.org>2019-09-21 19:33:25 +0000
commit0141c82eedbe525169546f6d30488149c3a7ed7a (patch)
treef9cf5d653d86e8d4bd3e36701de2780b4104d145 /buildtools
parent2291679e2b02e729e34ef848164d6630c5adc546 (diff)
downloadsamba-0141c82eedbe525169546f6d30488149c3a7ed7a.tar.gz
samba_autoconf.py: avoid inefficient string concatenations
Signed-off-by: Bjoern Jacke <bjacke@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Diffstat (limited to 'buildtools')
-rw-r--r--buildtools/wafsamba/samba_autoconf.py5
1 files changed, 2 insertions, 3 deletions
diff --git a/buildtools/wafsamba/samba_autoconf.py b/buildtools/wafsamba/samba_autoconf.py
index ee15e34b5ec..63664a41160 100644
--- a/buildtools/wafsamba/samba_autoconf.py
+++ b/buildtools/wafsamba/samba_autoconf.py
@@ -23,13 +23,12 @@ def DEFINE(conf, d, v, add_to_cflags=False, quote=False):
def hlist_to_string(conf, headers=None):
'''convert a headers list to a set of #include lines'''
- hdrs=''
hlist = conf.env.hlist
if headers:
hlist = hlist[:]
hlist.extend(TO_LIST(headers))
- for h in hlist:
- hdrs += '#include <%s>\n' % h
+ hdrs = "\n".join('#include <%s>' % h for h in hlist)
+
return hdrs