diff options
| author | Björn Jacke <bj@sernet.de> | 2019-08-25 23:02:37 +0200 |
|---|---|---|
| committer | Andrew Bartlett <abartlet@samba.org> | 2019-09-21 19:33:25 +0000 |
| commit | 432d9fd2214a4804a9cfefb9916e97efb9909c2c (patch) | |
| tree | 3a82089abdfb1255f0e33c04b81d167ed1850ad2 /buildtools | |
| parent | 8b43aabecbad2084169b229859bf5bfc9e2ddac0 (diff) | |
| download | samba-432d9fd2214a4804a9cfefb9916e97efb9909c2c.tar.gz | |
samba_deps.py avoid inefficient string concatenations
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Diffstat (limited to 'buildtools')
| -rw-r--r-- | buildtools/wafsamba/samba_deps.py | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/buildtools/wafsamba/samba_deps.py b/buildtools/wafsamba/samba_deps.py index 03c37079a8c..f400e1833a2 100644 --- a/buildtools/wafsamba/samba_deps.py +++ b/buildtools/wafsamba/samba_deps.py @@ -253,10 +253,8 @@ def add_init_functions(self): cflags.append('-DSTATIC_%s_MODULES_PROTO=%s' % (m, proto)) else: cflags.append('-DSTATIC_%s_MODULES=%s' % (m, ','.join(init_fn_list) + ',' + sentinel)) - proto='' - for f in init_fn_list: - proto += '_MODULE_PROTO(%s)' % f - proto += "extern void __%s_dummy_module_proto(void)" % (m) + proto = "".join('_MODULE_PROTO(%s)' % f for f in init_fn_list) +\ + "extern void __%s_dummy_module_proto(void)" % (m) cflags.append('-DSTATIC_%s_MODULES_PROTO=%s' % (m, proto)) self.cflags = cflags |