diff options
| author | Björn Jacke <bj@sernet.de> | 2019-08-25 22:53:59 +0200 |
|---|---|---|
| committer | Andrew Bartlett <abartlet@samba.org> | 2019-09-21 19:33:25 +0000 |
| commit | 2291679e2b02e729e34ef848164d6630c5adc546 (patch) | |
| tree | 71b37484315a0e41e221cd5a53e31f831541de2f /buildtools | |
| parent | dd0837c9a84bdbb98c9c31997c431173dfe6e714 (diff) | |
| download | samba-2291679e2b02e729e34ef848164d6630c5adc546.tar.gz | |
samba_abi.py: avoid inefficient string concatenations
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Diffstat (limited to 'buildtools')
| -rw-r--r-- | buildtools/wafsamba/samba_abi.py | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/buildtools/wafsamba/samba_abi.py b/buildtools/wafsamba/samba_abi.py index 5e7686da3d6..bf82fc5fe1f 100644 --- a/buildtools/wafsamba/samba_abi.py +++ b/buildtools/wafsamba/samba_abi.py @@ -72,9 +72,7 @@ def parse_sigs(sigs, abi_match): def save_sigs(sig_file, parsed_sigs): '''save ABI signatures to a file''' - sigs = '' - for s in sorted(parsed_sigs.keys()): - sigs += '%s: %s\n' % (s, parsed_sigs[s]) + sigs = "".join('%s: %s\n' % (s, parsed_sigs[s]) for s in sorted(parsed_sigs.keys())) return samba_utils.save_file(sig_file, sigs, create_dir=True) |