summaryrefslogtreecommitdiff
path: root/src/plugins/clearcase/clearcaseplugin.cpp
Commit message (Collapse)AuthorAgeFilesLines
* Remove unused includes of QFutureInterfaceJarek Kobus2023-05-041-1/+0
| | | | | | Change-Id: I70f5e842801b628c7f9ad4d433334ce04d4e648e Reviewed-by: Eike Ziller <eike.ziller@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
* Utils: Rename qtcprocess.{cpp,h} -> process.{cpp,h}Jarek Kobus2023-05-041-1/+1
| | | | | | | | Follows QtcProcess -> Process rename. Change-Id: I97235a9a40cb7fd52944515b7ab878d96528f919 Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
* Utils: Rename QtcProcess -> ProcessJarek Kobus2023-05-041-3/+3
| | | | | | | | Task-number: QTCREATORBUG-29102 Change-Id: Ibc264f9db6a32206e4097766ee3f7d0b35225a5c Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: hjk <hjk@qt.io>
* Utils: Rename asynctask.{cpp,h} -> async.{cpp,h}Jarek Kobus2023-05-031-1/+1
| | | | | | | Follows AsyncTask -> Async rename. Change-Id: I37f18368ab826c9960a24087b52f6691bb33f225 Reviewed-by: hjk <hjk@qt.io>
* Replace a few \returns by Returnshjk2023-03-241-1/+1
| | | | | Change-Id: I09c633e610421f5cc8257b15de60ffa98d890ee0 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* VcsBase: Use QtConcurrent invocation for async runJarek Kobus2023-03-091-7/+8
| | | | | | | Change-Id: Ia4e461c1a2e71d4c959f582e9ed464d4713b672a Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
* ProjectExplorer: Move some not-fully-session related bitshjk2023-03-011-3/+3
| | | | | | | | | | | | | | | ... out of SessionManager. The idea is to later move SessionManager into the Core plugin, which both is sensible conceptually and also prerequisite to merge the Bookmark plugin into TextEditor plugin. Currently, only the interface is split, as the load/save implemetations are non-mechanical to disentangle. Change-Id: I31631db3094ea192825a2ccaa6add6188662940b Reviewed-by: Eike Ziller <eike.ziller@qt.io> Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
* Translations: Change translation context prefix from "::" to "QtC::"Alessandro Portale2023-02-101-3/+3
| | | | | | | lupdate would be confused by translation contexts starting with :: Change-Id: Ie95e73436fd3cafc80a8e89f908efadc747e644c Reviewed-by: hjk <hjk@qt.io>
* ClearCasePlugin: Fix runCleartoolProcJarek Kobus2023-02-081-1/+1
| | | | | | | | | | Don't pass pointer to QtcProcess into CommandResult c'tor. Pass reference instead. Amends 0b7ee3220266388dbd3ce80673ec6c8b6f64e06e Change-Id: Icc779e6901faa2212609d52fad4bccbf7126a5c7 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Use simpler Plugin::initialize() when feasiblehjk2023-01-201-3/+1
| | | | | Change-Id: I567965d266f20526bda9f823e31a04b354d53fb1 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* VcsBase: Proliferate use of FilePathhjk2023-01-201-14/+16
| | | | | | | ... and update user code. Change-Id: I52c08e9e07238536d31fc72f97312ac582a1e32f Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* VcsBase: Convert to Tr::trhjk2023-01-181-3/+3
| | | | | | | | | | To reduce the amount of duplicated strings for translators to handle. The problem is not very prominent in vcsbase, but that's where we are moving everywhere else. Change-Id: Icb11fad3bccfea8a1408420e729566a75adccb66 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io> Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* VcsPlugins: Use multi-arg for stringsJarek Kobus2023-01-111-1/+1
| | | | | Change-Id: I8c1c62e3d2f98781ff1468b44ad11640b873695d Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Remove GPL-3.0+ from license identifiersKai Köhne2023-01-061-1/+1
| | | | | | | | | | | | | | | Since we also license under GPL-3.0 WITH Qt-GPL-exception-1.0, this applies only to a hypothetical newer version of GPL, that doesn't exist yet. If such a version emerges, we can still decide to relicense... While at it, replace (deprecated) GPL-3.0 with more explicit GPL-3.0-only Change was done by running find . -type f -exec perl -pi -e "s/LicenseRef-Qt-Commercial OR GPL-3.0\+ OR GPL-3.0 WITH Qt-GPL-exception-1.0/LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0/g" {} \; Change-Id: I5097e6ce8d10233993ee30d7e25120e2659eb10b Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* VcsBase & dependent: Fix const correctnessJarek Kobus2022-12-141-44/+39
| | | | | | | And some minor cleanups. Change-Id: Id0c2df6865ba84c054f0fb97c0ac42a76a128355 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* ClearCase: Re-use FilePath::removeRecursively()hjk2022-12-141-17/+2
| | | | | | Change-Id: Iac0e8fcd774c366289b0f854e8b4c310dd109901 Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
* ClearCase: Use a FilePath for the test filehjk2022-11-231-12/+14
| | | | | | Change-Id: I79b149df87d28e91f7692616dd9fdb1b925f7ab5 Reviewed-by: Christian Stenger <christian.stenger@qt.io> Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
* VCS: Simplify submit editor accept/close flowOrgad Shaneh2022-10-251-2/+2
| | | | | | | | | * Replace message box with an error on the output pane. * Separate logic for accept and close. Change-Id: Ib9fa201a1a67ee195086f7a22bc6678a9642452a Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: André Hartmann <aha_1980@gmx.de>
* VCS: Deduplicate some submit editor closing logicOrgad Shaneh2022-10-171-24/+1
| | | | | Change-Id: I622f5703c222a48606fcca3b99e87f9398e6a815 Reviewed-by: André Hartmann <aha_1980@gmx.de>
* VCS: Remove "Prompt to submit" settingsOrgad Shaneh2022-10-171-7/+1
| | | | | | Task-number: QTCREATORBUG-22233 Change-Id: Ifbfd738281066af7913357ff9e2466a6c983452c Reviewed-by: André Hartmann <aha_1980@gmx.de>
* VCS: Fix misuses of parentDir().absolutePath()Orgad Shaneh2022-10-111-5/+5
| | | | | | | absolutePath() *is* the parent directory. Change-Id: I59f2c4ae65b265270d432f381258b95c65e53581 Reviewed-by: hjk <hjk@qt.io>
* Port from qAsConst() to std::as_const()Marc Mutz2022-10-071-1/+1
| | | | | | | | | | | | | | We've been requiring C++17 since Qt 6.0, and our qAsConst use finally starts to bother us (QTBUG-99313), so time to port away from it now. Since qAsConst has exactly the same semantics as std::as_const (down to rvalue treatment, constexpr'ness and noexcept'ness), there's really nothing more to it than a global search-and-replace. Task-number: QTBUG-99313 Change-Id: I88edd91395849574436299b8badda21bb93bea39 Reviewed-by: hjk <hjk@qt.io>
* VcsBase: Use FilePath in editorTag()Jarek Kobus2022-10-061-4/+4
| | | | | Change-Id: I4093fa46a51767afd00a8de2f94986c708dc1efa Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* VcsBase: Move RunFlags into separate headerJarek Kobus2022-10-061-17/+16
| | | | | | | | | It is going to be used outside of VcsCommand, too. Use RunFlags enum as an argument to several functions instead of unsigned. Change-Id: I355c80a845a9b5982108fbde3412754392dce702 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* ClearCasePlugin: Remove runCleartoolSync()Jarek Kobus2022-10-051-41/+18
| | | | | | | Replace it with runCleartoolProc(). Change-Id: I04172aa1506cbe20e9c8d870b697b899cfcca7bf Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* ClearCasePlugin: Introduce runCleartoolProcJarek Kobus2022-10-051-27/+30
| | | | | | | | | | | | | Don't use VcsCommand when the only passed flag is NoOutput as in this case VcsCommand is the same as QtcProcess. Add runCleartoolProc and implement it using QtcProcess. Use it whenever NoOutput has been passed to runCommand. Some codepath, like runCleartoolSync() or ccGetActiveVobs() has been called from non-GUI thread - be on the safe side and use QtcProcess in these cases. Change-Id: I2d29947393bd43af193a53e3f8e89e1b6b4b86fa Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* ClearCasePlugin: Replace timeout with timeout multiplierJarek Kobus2022-10-051-43/+32
| | | | | | | | Give it default value of 1. Move this arg as the last one (only 2 non-default usages). Change-Id: I8c0bee7988436b899c8ae5cb7b96b7fe534d265f Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* VcsCommand: Make runCommand() a static methodJarek Kobus2022-10-051-8/+4
| | | | | | | | | | | | | | | And rename it to runBlocking() in order to conform a bit more to QtcProcess API. In case of blocking run there is no need to instantiate VcsCommand on user side. This nicely draw a line between async usages (i.e. when start() is called and we need an instance) and blocking ones (i.e. when runBlocking() is called). Change-Id: I1ba94ee36c92956d5044236cb9e2dd896bf3cfcf Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* VcsCommand: Change the default logic for fully syncJarek Kobus2022-10-051-24/+25
| | | | | | | | | | | | | | | Remove VcsCommand::FullySynchronous flag. Rename VcsCommand::NoFullySync into UseEventLoop. By default the command will run fully synchronous (i.e. without nested event loop). Only when UseEventLoop is specified, and the command runs in main thread, the nested event loop will be used. This change should preserve the current behavior on all code paths. Change-Id: Id4bbaf68402ceed5e3fcc6f294521e87eb0b8d4d Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* ClearCase: Move to Tr::trhjk2022-09-291-57/+56
| | | | | Change-Id: I0f65dfab1c73315d6877cfcc8a04cf202c0a3cdf Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* ClearCase: Inline undocheckout.uihjk2022-09-291-29/+77
| | | | | | Change-Id: Id687cc5346cbbac01258efdf28eac427e7d97581 Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
* ClearCasePlugin: Reuse CommandResultJarek Kobus2022-09-211-236/+207
| | | | | | | | Get rid of ClearCaseResponse struct. Replace foreach with range-based for loops. Change-Id: Id78e2ca3598c16ad16ebaeddae73a140e3473936 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Use SPDX license identifiersLucie Gérard2022-08-261-25/+2
| | | | | | | | | Replace the current license disclaimer in files by a SPDX-License-Identifier. Task-number: QTBUG-67283 Change-Id: I708fd1f9f2b73d60f57cc3568646929117825813 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* ClearCase: Remove unused includesJarek Kobus2022-08-031-36/+28
| | | | | | | | Add some forward declarations. Change-Id: If7b55d57484f9ab7b03e3919a7ba52f243fc5de0 Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
* ClearCase: Simplify isConfigured()Jarek Kobus2022-08-031-2/+1
| | | | | | | | Make executable check inside ClearCaseSync::run() consistent with isConfigured(). Change-Id: Idc08dcdf87005937b1299a0d033c4cf2503f63a4 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* ClearCaseSettings: Use FilePath for ccBinaryPathJarek Kobus2022-08-021-9/+5
| | | | | Change-Id: I0de348d0b99a1f81d75418a7927c989283c4137a Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* VcsCommand: Simplify public runCommand()Jarek Kobus2022-08-021-1/+1
| | | | | | | | | Get rid of unused workingDirectory (default working directory will be used) and exitCodeInterpreter. Simplify internals a bit. Change-Id: I2a7547e5a594dd7a21f390daeb06778656e9e971 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Move ShellCommand into VcsBase pluginJarek Kobus2022-08-011-7/+7
| | | | | | | | | | Rename it to VcsCommand. Move also ShellCommandPage into VcsBase plugin. Change-Id: I335ac47e3090f2be497643ebcda0eaad2987ac81 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* ShellCommand: Introduce CommandResult structureJarek Kobus2022-07-291-8/+6
| | | | | | | | | Don't require QtcProcess instance when calling ShellCommand::runCommand(). Change-Id: Ie0287d91c1807465eab12be7eaa2eac561179af7 Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* ClearCasePlugin: Introduce s_verboseRun helperJarek Kobus2022-07-141-23/+20
| | | | | Change-Id: I08abc4f45ee17574e9a642f5b971fc8278e02ab0 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* VcsBase: Hide VcsCommand classJarek Kobus2022-07-131-5/+7
| | | | | | | | | | | | Make it an implementation detail. Introduce VcsBaseClient::createVcsCommand() method instead for instantiating VcsCommands. Replace all occuriences of VcsBase::VcsCommand in public API with Utils::ShellCommand. Change-Id: Ie438cc3a5e867b3ee8f9e935b56b2f16ea453f8a Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* ShellCommand: Merge VcsCommand::VcsRunFlags into RunFlagsJarek Kobus2022-07-121-24/+18
| | | | | | | Use ShellCommand class name in signal-slot connections. Change-Id: Id50ee6887708558a2ba0972ece6c420b0be36f72 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* ClearCase: Remove unused localsChristian Stenger2022-07-111-2/+0
| | | | | Change-Id: Ib62cbadc865ee8ab61daf20b8809aff1af2fa444 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Utils: use cleaned stdout all over the place againDavid Schulz2022-06-171-2/+2
| | | | | | | Amends 5ee880ce5e6998170823e6fc9afb6b6c36c6170a Change-Id: Ie0202db7d8455372c3697087d9571db6706b45a1 Reviewed-by: hjk <hjk@qt.io>
* QtcProcess: Limit the inclusion of qtcprocess.hJarek Kobus2022-03-021-3/+3
| | | | | | | | | | Move the rest of QtcProcess enums to processenums.h. Move ExitCodeInterpreter into processenums.h. Remove superfluous Utils:: prefix. Change-Id: Iaa596f353d33d6930085a621b114cc15a35caa80 Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
* QtcProcess: Get rid of setProcessUserEventWhileRunning()Jarek Kobus2022-01-251-2/+1
| | | | | | | | | | | Introduce EventLoopMode enum and pass it to the QtcProcess::runBlocking() instead. There is no need to store this setting. By default this value is NoEventLoop. Change-Id: Icad98b77bec5280b79039b7e5aa4ec408261521c Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: hjk <hjk@qt.io> Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
* Merge remote-tracking branch 'origin/6.0'Eike Ziller2021-11-041-1/+0
|\ | | | | | | Change-Id: I560583b200db8f180574256d6d851a867be11c37
| * Remove unneeded includes of QProcess from cpp filesJarek Kobus2021-11-011-1/+0
| | | | | | | | | | | | | | | | QProcess wasn't used in these files. Change-Id: I24900bcf312eb6ea1ca3bc0c753cebb505ec552b Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: hjk <hjk@qt.io>
* | EditorManager: Remove QString openEditor(At) overloadsEike Ziller2021-11-021-2/+3
|/ | | | | | | | In favor of the FilePath/Link ones. Change-Id: I5caf9e0f8de304ff4ee12329557aa50a6f3a0c69 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: David Schulz <david.schulz@qt.io>
* ClearCase: Minor cleanupOrgad Shaneh2021-10-131-6/+2
| | | | | | | Replace iteration over all documents with a faster lookup. Change-Id: Iccc20ff2e5a44eef9d0bc925e25ef5c7ebaa98e9 Reviewed-by: hjk <hjk@qt.io>