summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Utils: Fix hasSuppressedQuestionsMarcus Tillmanns2023-05-101-8/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | QSettings::childKeys() only returns direct child values, not child groups. Therefore we also need to check QSettings::childGroups() here. We don't need to iterate all the keys. Keys are only created with "true" value. Change-Id: Ie4653dca1dfbad85ab895440a756c8e03aa78118 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* | | Locator tests: Remove tests for old matchesFor implementationJarek Kobus2023-05-104-197/+31
| | | | | | | | | | | | | | | | | | | | | Change-Id: I0d0293cc248dc4208cf5d50de468ccf94b4bb960 Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* | | Remove ineffective resize() callsAlessandro Portale2023-05-1031-53/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This removes apparently unnecessary resize() calls on QWidgets based forms which get anyways added to layouts and resized. Most of these size values looked "accidental", i.e. neither divisible by 2 nor by 5, in most cases a remnant from the ui inlining. Change-Id: I95da3b93f2915ef955b5235e5c2ecc94b51f813a Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: hjk <hjk@qt.io>
* | | LayoutBuilder: Avoid leak warnings in Application::exec()Alessandro Portale2023-05-101-2/+2
| | | | | | | | | | | | | | | Change-Id: I9c05f3015b120220408076d58d29983d2194d9e1 Reviewed-by: hjk <hjk@qt.io>
* | | Utils: move TextPosition/Range to textutilsDavid Schulz2023-05-1011-91/+76
| | | | | | | | | | | | | | | Change-Id: Id94a7a96f3b0f978e94850d67eb4b8fba6c18fe2 Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
* | | Utils: Improve FilePath::sortMarcus Tillmanns2023-05-102-5/+63
| | | | | | | | | | | | | | | | | | | | | Remove the conversion to/from QString for sorting. Change-Id: I89921328b6d9e952c802d41998495bd2ffbb9f99 Reviewed-by: hjk <hjk@qt.io>
* | | Core: Remove QObject base of IOptionsPagehjk2023-05-101-3/+3
| | | | | | | | | | | | | | | | | | Change-Id: I714fd0cdd542da947deb2a8395dec87bb40fca75 Reviewed-by: Christian Stenger <christian.stenger@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
* | | Layouting: Remove some now unused functionshjk2023-05-101-15/+1
| | | | | | | | | | | | | | | Change-Id: I9e91bdbf68c38da22bd2378cb7d9596306bbb413 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* | | Help: Remove dependency of IOptionPage's QObject basehjk2023-05-103-14/+7
| | | | | | | | | | | | | | | | | | Change-Id: Ide7b16406947cc4865653661d0020d657671bc16 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* | | CPlusPlus: Don't double uniquifyMarcus Tillmanns2023-05-102-4/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | CppDocument::includedFiles removes duplicates. Snapshot::allIncludesForDocument also removes duplicates. Once is enough. This doubles test scan performance on my machine. Change-Id: I892908cf0820cfa11854ac3d82e9175d1fc38043 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | | Tasking::Tree: Rename Tree into TaskTreeTaskJarek Kobus2023-05-107-12/+12
| | | | | | | | | | | | | | | | | | | | | Task-number: QTCREATORBUG-29102 Change-Id: I70073bcb44a712c427c8c5aea42c48dbc30eebe0 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: hjk <hjk@qt.io>
* | | TaskTree: Adapt docs naming to the recent renamingJarek Kobus2023-05-101-64/+64
| | | | | | | | | | | | | | | | | | | | | Task-number: QTCREATORBUG-29102 Change-Id: I1edf4d4e38c8853560bca3d3a6da55322a6764d6 Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
* | | Tasking::Transfer: Rename Transfer into FileTransferTaskJarek Kobus2023-05-107-11/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rename TransferTest into FileTransferTestTask. Rename adapters accordingly. Task-number: QTCREATORBUG-29102 Change-Id: I50c8b8d64abd7d3063044eaf2e0daceb01e8d388 Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
* | | Process: Rename QtcProcessPrivate -> ProcessPrivateJarek Kobus2023-05-1018-57/+57
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rename the logging category for Process. Fix inline comments accordingly. Adapt warning/debug messages accordingly. Change-Id: I2b1f0f558701def3afa3c1b04adf629833dba9e7 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: hjk <hjk@qt.io>
* | | Core: Introduce a IOptionsPage::setLayout(const LayoutItem)hjk2023-05-102-0/+12
| | | | | | | | | | | | | | | | | | | | | Helps to move the lambda setup off the user code. Change-Id: I0de43f53fc9018913340e81b5c1e8e69df067bd6 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* | | Core: Introduce PagedSettingshjk2023-05-101-0/+7
| | | | | | | | | | | | | | | | | | | | | An AspectContainer with an IOptionsPage. Change-Id: I03d460f788cfcb2c631b2789bc8f7c74a0b62a37 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* | | LayoutBuilder: Rename Id to IDhjk2023-05-103-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | The Id was only used in the demo. "ID" is Not exactly canonical naming, but this clashes often with Utils::Id, so mis-spell until we settle on a proper name. Change-Id: I6fdf806c41abf224f7422ec6c9263db3eb357190 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* | | BareMetal: Use a functor to apply settingshjk2023-05-101-2/+2
| | | | | | | | | | | | | | | Change-Id: I5e770e6c51a3c709b38879b75c172d4c25e27085 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* | | LayoutBuilder: Fix Splitter constructionhjk2023-05-101-2/+16
| | | | | | | | | | | | | | | | | | | | | | | | QSplitter is different insofar as that it doesn't have a Layout, but a list of child widgets. Change-Id: I4e1076e39d20df409c4bab93d79770b6d0e5aa8d Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* | | CppEditor: reduce complexity of getting previous lineDavid Schulz2023-05-102-15/+2
| | | | | | | | | | | | | | | | | | | | | for a given text cursor. Change-Id: I43591b529e9d04b3ef013db3b9b30cf37773c115 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | | Terminal: Remove clazy warningAlessandro Portale2023-05-091-1/+1
| | | | | | | | | | | | | | | | | | | | | Don't call QList::constEnd() on temporary [clazy-temporary-iterator] Change-Id: I92108a5c7706173097ae643774af1dd7d7acb5dd Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
* | | MultiTextCursor: iterate over map entriesDavid Schulz2023-05-091-9/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will ensure that the cursors are iterated over in the order they appear in the document. This fixes an issue on copy and paste a multitext cursors, since the text was copied in the order inside the document, but inserted in the order how the different cursors were added to the multi text cursor. Fixes: QTCREATORBUG-29117 Change-Id: I8475cde7129c378ec7862482226db25e40f61e1b Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* | | Markdown: Support bookmarks and jumping to search resultsEike Ziller2023-05-092-13/+36
| | | | | | | | | | | | | | | | | | | | | | | | Redirect the currentLine/Column and gotoLine functions to the text editor and ensure that it is visible for gotoLine. Change-Id: I546e2cb1761363e3a75f9adeebcba195e312f00b Reviewed-by: David Schulz <david.schulz@qt.io>
* | | Terminal: Fix endless loopMarcus Tillmanns2023-05-093-23/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | An error in the QPoint constructor version of CellIterator meant that m_pos could be bigger than m_maxpos. CellIterator(,State) was also simplified to be more correct. Change-Id: Ib67b26695fae1e1857d106319037ca8f63bcb250 Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: Cristian Adam <cristian.adam@qt.io>
* | | Terminal: Ensure terminal is visibleMarcus Tillmanns2023-05-093-0/+11
| | | | | | | | | | | | | | | | | | | | | When restarting an app, make sure the terminal is visible and focused. Change-Id: I305eb59ddf2f5e0f2844d47e51500953c3145c38 Reviewed-by: Cristian Adam <cristian.adam@qt.io>
* | | Terminal: Fix cursor/viewport updatesMarcus Tillmanns2023-05-091-7/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | Under some font sizes the cursor size and cell size were not correctly aligned on the pixel grid, leaving behind artifacts of prior draws. Change-Id: I25e6efdc44102f24672912e1e56c31be0c686b89 Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: Cristian Adam <cristian.adam@qt.io>
* | | Terminal: Fix shell integration for login shellsMarcus Tillmanns2023-05-091-4/+4
| | | | | | | | | | | | | | | Change-Id: I78cc4b60b4e2164752b7b65e2e61659e5d5bbe22 Reviewed-by: Cristian Adam <cristian.adam@qt.io>
* | | Terminal: Combine settingsMarcus Tillmanns2023-05-091-6/+1
| | | | | | | | | | | | | | | Change-Id: Ic9e3ac9bdba73eb99e8177083e08c8b4b1765972 Reviewed-by: Cristian Adam <cristian.adam@qt.io>
* | | FileSearch: Get rid of FileSearchResultJarek Kobus2023-05-0918-292/+287
| | | | | | | | | | | | | | | | | | | | | | | | | | | Use SearchResultItem instead. This change should reduce the remaining freeze described in a9eb732ce6763e22badd92fc8523cebe84b09a84 even more. Change-Id: I102b82ed5677360ccd9e425dd0bdd941d87116f0 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* | | ProjectExplorer: Prevent context menu on ProjectSelectorAlessandro Portale2023-05-091-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | The context menu on the ProjectSelector (outside the "SelectorTree") does not make much sense and pops up with an offset. Change-Id: I79aa3157e04b9d343077fdbc87b8f7cd891426b4 Reviewed-by: hjk <hjk@qt.io> Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
* | | Copilot: Use functor to apply settingshjk2023-05-091-5/+4
| | | | | | | | | | | | | | | Change-Id: Ie17273a4fd55c2144b2751166fb69bd523033321 Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
* | | GitLab: Shift responsibility to signal changeshjk2023-05-096-25/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | ... from the option pasge (factory) to the settings (storage). This will help with removing the QObject base from IOptionPage Change-Id: I04a6b499bdca6065bf8f742b4624beabe7d8f8cc Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* | | CppEditor: Remove SendDocumentTrackerChristian Kandeler2023-05-097-318/+2
| | | | | | | | | | | | | | | | | | | | | | | | This was forgotten in the clangbackend removal. Change-Id: I73a3016504ee4af5d921e387f1502d8906161c1a Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* | | Help: Use functors and layouting in FilterSettingsPageWidgethjk2023-05-091-34/+24
| | | | | | | | | | | | | | | | | | Change-Id: Ib163a41feeafebf4a80b587b6cebbf83cc8e97cb Reviewed-by: Christian Stenger <christian.stenger@qt.io> Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
* | | Debugger: Fix compatibility for debugger engine statesChristian Stenger2023-05-091-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | ..when switching back to an older version of QC. Amends e0219fad4d9b540145739832a5d91045a3f3fd0e. Change-Id: I3662eb95cf1ae72f92688f12cc15b7a42fb1452c Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* | | ProjectExplorer: Simplify a complex translatable stringhjk2023-05-0912-34/+24
| | | | | | | | | | | | | | | Change-Id: I51a3f18b2c05eb7371d77c18f3f390f5809e2920 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* | | VCS: fix compile of CommonVcsSettingsDavid Schulz2023-05-091-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | Remove undeclared operator definition Amends 65281429d45673b189557ebd0cb0ba52f8653d12 Change-Id: I30ffd5d7b4a50acd9db7acef1668a26c942cc50c Reviewed-by: hjk <hjk@qt.io>
* | | Utils: Introduce QTC_STATIC_SCOPED_TIMER()Jarek Kobus2023-05-096-48/+105
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This macro, similar to QTC_SCOPED_TIMER(), measures the time spent in a block of code. In addition, the time spent in a block is saved in a static variable. This macro enables measuring a cumulative time spent inside a certain block of code for all invocations. When a long freeze is being tracked, and QTC_SCOPED_TIMER() indicates that the most of the freeze is spent inside a loop with a big amount of iterations, placing QTC_STATIC_SCOPED_TIMER() inside the loop may detect the part of the loop that composes in total for the longest freeze. In contrary to the QTC_SCOPED_TIMER(), this macro it doesn't print the message when it's entered. It prints the output at first hit, and later, as not to clog the debug output, only at 10ms resolution. Change-Id: I3360a3ab9147d544f90ce914fb78359f7179c767 Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
* | | VcsPlugin: shift signalling of settings changeshjk2023-05-093-10/+10
| | | | | | | | | | | | | | | | | | | | | To allow removing the QObject ineritance of IOptionPage Change-Id: Id230ee9230dd1bee094b19b5a22d61d37e650d27 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* | | Git: Use LayoutBuilder in Gerrit options pagehjk2023-05-084-84/+78
| | | | | | | | | | | | | | | | | | | | | | | | Move towards using aspects and away from IOptionPage's QObject base. Change-Id: I07850a6b8e9fa7d2591efc6f76a23f249dfc164f Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* | | Perforce: Don't use Option page as guard objecthjk2023-05-081-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | There's a plan to remove the QObject base from IOptionPage Change-Id: I142d2323f86e46d7758f8bd9a65c988988a18ed1 Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* | | QmlDesignerBase: Remove the dependency on IOptionPage's QObject basehjk2023-05-082-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | The base will be cut soonish, and the only use here was tr() with a (wrong) context. Use StudioSettingsPage for that now. Change-Id: I41e4b737713591e002c126bbf97226de7c3f784f Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
* | | Git: Small simplification to Gerrit "plugin" setuphjk2023-05-083-14/+13
| | | | | | | | | | | | | | | | | | | | | | | | The indirection is not needed. It's not really stand-alone, and not touched before GitPlugin::initialize(). Change-Id: If8552dc69ff9efa18a3f1d6d998a8f28ab65e501 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* | | CppEditor: Refactor "insert member from use" quickfixesChristian Kandeler2023-05-082-109/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | The interfaces make much more sense now, and the coding style is taken into account (except for the fallback case where the user enters the type). Change-Id: If08dfc41ebd63287fb5b0b187944e7fdf08b0823 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* | | Core: Remove QObject inheritance of IOptionsPageProviderhjk2023-05-083-8/+5
| | | | | | | | | | | | | | | | | | | | | This was not really used. Change-Id: I86049697d211d88827a9633b367d2121fa8d1f1c Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* | | Editor: Fix initial enabled state of margin settingsDavid Schulz2023-05-081-0/+2
| | | | | | | | | | | | | | | Change-Id: I0adff884743dd8301a9c7f8b7a44f94658af4b5f Reviewed-by: hjk <hjk@qt.io>
* | | Core: Remove parent pointer from IOptionPage constructorhjk2023-05-083-5/+4
| | | | | | | | | | | | | | | | | | | | | Not used anymore. Change-Id: Ic44ce021b1f952337a3193454b5b6649d5847446 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* | | CMake: Fix setting additional project files for file watchingEike Ziller2023-05-083-10/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Amends d8be2491a5f5cfdc512f63c766a550dd43694063 The change above introduced FileApiReader::takeCMakeFileInfos and uses it to move the information about additional CMake files out of the FileApiReader. But that now emptied variable was later used to inform the project about these additional files. So, that broke the automatic running of CMake when project files (except the toplevel one) changes. Instead use the list of additional files that now lives in the CMakeBuildSystem for that purpose. Change-Id: I1062593029880af9d4c70e72e1bd101d40ad0c00 Reviewed-by: Cristian Adam <cristian.adam@qt.io>
* | | Fix environment auto testhjk2023-05-081-1/+1
| | | | | | | | | | | | | | | | | | | | | Amends 1e1befd9eb6. Change-Id: Iecd06ee06081057208a2b3387d618142dc74d0bd Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
* | | VcsBase: Move some private pieces off vcsplugin.hhjk2023-05-082-34/+39
| | | | | | | | | | | | | | | | | | | | | By themselves not worth a pimpl, but since we have one already... Change-Id: I867e68c5e82f71ebbe16a55eb190d87f981a550b Reviewed-by: Orgad Shaneh <orgads@gmail.com>
View Lorry Controller Status