diff options
author | Nikolai Kosjar <nikolai.kosjar@digia.com> | 2014-09-11 10:54:47 +0200 |
---|---|---|
committer | Nikolai Kosjar <nikolai.kosjar@digia.com> | 2014-09-22 10:49:25 +0200 |
commit | f4adc00b99c4a8b993eb57c52fc2979cca45b8f2 (patch) | |
tree | 2dab4ed04181c1beeb3e48e0106832b56b5d9ec8 /src | |
parent | af34a5b9b43119ef0bde6836b26e885664fe6683 (diff) | |
download | qt-creator-f4adc00b99c4a8b993eb57c52fc2979cca45b8f2.tar.gz |
CppEditor: Tests: Fix leaking IAssistProcessor and IAssistProposal
...in VirtualFunctionTestAssistProvider.
Change-Id: I6472a599ca12d72e8df8e6f416eaa02c27ef1cc6
Reviewed-by: Christian Stenger <christian.stenger@digia.com>
Diffstat (limited to 'src')
-rw-r--r-- | src/plugins/cppeditor/followsymbol_switchmethoddecldef_test.cpp | 15 |
1 files changed, 10 insertions, 5 deletions
diff --git a/src/plugins/cppeditor/followsymbol_switchmethoddecldef_test.cpp b/src/plugins/cppeditor/followsymbol_switchmethoddecldef_test.cpp index 5da21718a1..adab84088e 100644 --- a/src/plugins/cppeditor/followsymbol_switchmethoddecldef_test.cpp +++ b/src/plugins/cppeditor/followsymbol_switchmethoddecldef_test.cpp @@ -34,6 +34,8 @@ #include "cppvirtualfunctionassistprovider.h" #include "cppvirtualfunctionproposalitem.h" +#include <cpptools/cpptoolstestcase.h> + #include <texteditor/codeassist/genericproposalmodel.h> #include <texteditor/codeassist/iassistprocessor.h> #include <texteditor/codeassist/iassistproposal.h> @@ -123,16 +125,19 @@ public: { VirtualFunctionAssistProvider::configure(params); - IAssistProcessor *processor = createProcessor(); + const QScopedPointer<IAssistProcessor> processor(createProcessor()); AssistInterface *assistInterface = m_editorWidget->createAssistInterface(FollowSymbol, ExplicitlyInvoked); - IAssistProposal *immediateProposal = processor->immediateProposal(assistInterface); - IAssistProposal *finalProposal = processor->perform(assistInterface); + + using CppTools::Tests::IAssistProposalScopedPointer; + const IAssistProposalScopedPointer immediateProposal( + processor->immediateProposal(assistInterface)); + const IAssistProposalScopedPointer finalProposal(processor->perform(assistInterface)); VirtualFunctionAssistProvider::clearParams(); - m_immediateItems = itemList(immediateProposal->model()); - m_finalItems = itemList(finalProposal->model()); + m_immediateItems = itemList(immediateProposal.d->model()); + m_finalItems = itemList(finalProposal.d->model()); return false; } |