Core: De-pure IOutputPane::visibilityChanged()

Most implementations are empty.

Change-Id: I811cacfc2918c8b2803798c4f5d3dabc7d60ccd1
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: hjk <hjk@qt.io>

16 files changed, 5 insertions, 37 deletions

diff --git a/src/plugins/autotest/testresultspane.cpp b/src/plugins/autotest/testresultspane.cpp
index c3518b44e7..8a6ef9022d 100644
--- a/src/plugins/autotest/testresultspane.cpp
+++ b/src/plugins/autotest/testresultspane.cpp
@@ -343,10 +343,6 @@ void TestResultsPane::clearContents()
     clearMarks();
 }
 
-void TestResultsPane::visibilityChanged(bool /*visible*/)
-{
-}
-
 void TestResultsPane::setFocus()
 {
 }
diff --git a/src/plugins/autotest/testresultspane.h b/src/plugins/autotest/testresultspane.h
index 658165f01d..0f3d05c1cf 100644
--- a/src/plugins/autotest/testresultspane.h
+++ b/src/plugins/autotest/testresultspane.h
@@ -85,7 +85,6 @@ public:
     QString displayName() const override;
     int priorityInStatusBar() const override;
     void clearContents() override;
-    void visibilityChanged(bool visible) override;
     void setFocus() override;
     bool hasFocus() const override;
     bool canFocus() const override;
diff --git a/src/plugins/coreplugin/ioutputpane.h b/src/plugins/coreplugin/ioutputpane.h
index 8d3bfc50ef..68d62550a4 100644
--- a/src/plugins/coreplugin/ioutputpane.h
+++ b/src/plugins/coreplugin/ioutputpane.h
@@ -58,7 +58,7 @@ public:
     virtual int priorityInStatusBar() const = 0;
 
     virtual void clearContents() = 0;
-    virtual void visibilityChanged(bool visible) = 0;
+    virtual void visibilityChanged(bool visible);
 
     virtual void setFocus() = 0;
     virtual bool hasFocus() const = 0;
diff --git a/src/plugins/coreplugin/messageoutputwindow.cpp b/src/plugins/coreplugin/messageoutputwindow.cpp
index 384b34c113..97b47a1e2f 100644
--- a/src/plugins/coreplugin/messageoutputwindow.cpp
+++ b/src/plugins/coreplugin/messageoutputwindow.cpp
@@ -105,10 +105,6 @@ QString MessageOutputWindow::displayName() const
     return tr("General Messages");
 }
 
-void MessageOutputWindow::visibilityChanged(bool /*b*/)
-{
-}
-
 void MessageOutputWindow::append(const QString &text)
 {
     m_widget->appendMessage(text, Utils::DebugFormat);
diff --git a/src/plugins/coreplugin/messageoutputwindow.h b/src/plugins/coreplugin/messageoutputwindow.h
index 152a707702..e43688b319 100644
--- a/src/plugins/coreplugin/messageoutputwindow.h
+++ b/src/plugins/coreplugin/messageoutputwindow.h
@@ -45,7 +45,6 @@ public:
     QString displayName() const override;
     int priorityInStatusBar() const override;
     void clearContents() override;
-    void visibilityChanged(bool visible) override;
 
     void append(const QString &text);
     bool canFocus() const override;
diff --git a/src/plugins/coreplugin/outputpanemanager.cpp b/src/plugins/coreplugin/outputpanemanager.cpp
index 4240c1120c..92008d6b04 100644
--- a/src/plugins/coreplugin/outputpanemanager.cpp
+++ b/src/plugins/coreplugin/outputpanemanager.cpp
@@ -126,6 +126,10 @@ QList<QWidget *> IOutputPane::toolBarWidgets() const
     return widgets << m_zoomInButton << m_zoomOutButton;
 }
 
+void IOutputPane::visibilityChanged(bool /*visible*/)
+{
+}
+
 void IOutputPane::setFont(const QFont &font)
 {
     emit fontChanged(font);
diff --git a/src/plugins/debugger/console/console.cpp b/src/plugins/debugger/console/console.cpp
index 1b29f70d61..074d1f3c8c 100644
--- a/src/plugins/debugger/console/console.cpp
+++ b/src/plugins/debugger/console/console.cpp
@@ -175,10 +175,6 @@ void Console::clearContents()
     m_consoleItemModel->clear();
 }
 
-void Console::visibilityChanged(bool /*visible*/)
-{
-}
-
 bool Console::canFocus() const
 {
     return true;
diff --git a/src/plugins/debugger/console/console.h b/src/plugins/debugger/console/console.h
index 8ad12eac69..10800e93ef 100644
--- a/src/plugins/debugger/console/console.h
+++ b/src/plugins/debugger/console/console.h
@@ -61,7 +61,6 @@ public:
     QString displayName() const override { return tr("QML Debugger Console"); }
     int priorityInStatusBar() const override;
     void clearContents() override;
-    void visibilityChanged(bool visible) override;
     bool canFocus() const override;
     bool hasFocus() const override;
     void setFocus() override;
diff --git a/src/plugins/projectexplorer/appoutputpane.cpp b/src/plugins/projectexplorer/appoutputpane.cpp
index 63a9377df7..95f04e20c5 100644
--- a/src/plugins/projectexplorer/appoutputpane.cpp
+++ b/src/plugins/projectexplorer/appoutputpane.cpp
@@ -341,10 +341,6 @@ void AppOutputPane::clearContents()
         currentWindow->clear();
 }
 
-void AppOutputPane::visibilityChanged(bool /* b */)
-{
-}
-
 bool AppOutputPane::hasFocus() const
 {
     QWidget *widget = m_tabWidget->currentWidget();
diff --git a/src/plugins/projectexplorer/appoutputpane.h b/src/plugins/projectexplorer/appoutputpane.h
index f682cfe296..24728d5e71 100644
--- a/src/plugins/projectexplorer/appoutputpane.h
+++ b/src/plugins/projectexplorer/appoutputpane.h
@@ -70,7 +70,6 @@ public:
     QString displayName() const override;
     int priorityInStatusBar() const override;
     void clearContents() override;
-    void visibilityChanged(bool) override;
     bool canFocus() const override;
     bool hasFocus() const override;
     void setFocus() override;
diff --git a/src/plugins/projectexplorer/compileoutputwindow.cpp b/src/plugins/projectexplorer/compileoutputwindow.cpp
index 97ab9b69be..9d8ad02a78 100644
--- a/src/plugins/projectexplorer/compileoutputwindow.cpp
+++ b/src/plugins/projectexplorer/compileoutputwindow.cpp
@@ -215,9 +215,6 @@ void CompileOutputWindow::clearContents()
     m_taskPositions.clear();
 }
 
-void CompileOutputWindow::visibilityChanged(bool)
-{ }
-
 int CompileOutputWindow::priorityInStatusBar() const
 {
     return 50;
diff --git a/src/plugins/projectexplorer/compileoutputwindow.h b/src/plugins/projectexplorer/compileoutputwindow.h
index a146ea16cb..babdfc17df 100644
--- a/src/plugins/projectexplorer/compileoutputwindow.h
+++ b/src/plugins/projectexplorer/compileoutputwindow.h
@@ -60,7 +60,6 @@ public:
     QString displayName() const override { return tr("Compile Output"); }
     int priorityInStatusBar() const override;
     void clearContents() override;
-    void visibilityChanged(bool visible) override;
     bool canFocus() const override;
     bool hasFocus() const override;
     void setFocus() override;
diff --git a/src/plugins/serialterminal/serialoutputpane.cpp b/src/plugins/serialterminal/serialoutputpane.cpp
index 0ef4a3544a..3d23606fa4 100644
--- a/src/plugins/serialterminal/serialoutputpane.cpp
+++ b/src/plugins/serialterminal/serialoutputpane.cpp
@@ -210,11 +210,6 @@ void SerialOutputPane::clearContents()
         currentWindow->clear();
 }
 
-void SerialOutputPane::visibilityChanged(bool)
-{
-    // Unused but pure virtual
-}
-
 bool SerialOutputPane::canFocus() const
 {
     return m_tabWidget->currentWidget();
diff --git a/src/plugins/serialterminal/serialoutputpane.h b/src/plugins/serialterminal/serialoutputpane.h
index 944b008ab1..24249fd841 100644
--- a/src/plugins/serialterminal/serialoutputpane.h
+++ b/src/plugins/serialterminal/serialoutputpane.h
@@ -76,7 +76,6 @@ public:
 
     int priorityInStatusBar() const final;
     void clearContents() final;
-    void visibilityChanged(bool) final;
     bool canFocus() const final;
     bool hasFocus() const final;
     void setFocus() final;
diff --git a/src/plugins/todo/todooutputpane.cpp b/src/plugins/todo/todooutputpane.cpp
index a4a3fa1cce..30be160d56 100644
--- a/src/plugins/todo/todooutputpane.cpp
+++ b/src/plugins/todo/todooutputpane.cpp
@@ -94,11 +94,6 @@ void TodoOutputPane::clearContents()
     clearKeywordFilter();
 }
 
-void TodoOutputPane::visibilityChanged(bool visible)
-{
-    Q_UNUSED(visible)
-}
-
 void TodoOutputPane::setFocus()
 {
     m_todoTreeView->setFocus();
diff --git a/src/plugins/todo/todooutputpane.h b/src/plugins/todo/todooutputpane.h
index 78b0aff45d..11f259cfaf 100644
--- a/src/plugins/todo/todooutputpane.h
+++ b/src/plugins/todo/todooutputpane.h
@@ -60,7 +60,6 @@ public:
     QString displayName() const override;
     int priorityInStatusBar() const override;
     void clearContents() override;
-    void visibilityChanged(bool visible) override;
     void setFocus() override;
     bool hasFocus() const override;
     bool canFocus() const override;