diff options
| author | Cristian Adam <cristian.adam@qt.io> | 2019-09-24 10:46:13 +0200 |
|---|---|---|
| committer | Cristian Adam <cristian.adam@qt.io> | 2019-09-24 11:30:44 +0000 |
| commit | 1e9b1dcaec31884725daa0c200a2f6cb862febf3 (patch) | |
| tree | c8d12a5729feb496ccbbae54f376330edbd11a4b /src/tools | |
| parent | bcaeb73e68b1880848252c634626c57bd6f18221 (diff) | |
| download | qt-creator-1e9b1dcaec31884725daa0c200a2f6cb862febf3.tar.gz | |
Clangbackend: Use Qt debugging instead of std::cerr
The arguments passed to libclang were only passed to std::cerr,
which and never reached Windows logging.
On Windows the clang*.exe have a qMessageHandler which forwards
the message to windows logging and std::cerr.
Change-Id: I97b0856ae2b3f44a991c9d292a15db9f3b071a0d
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
Diffstat (limited to 'src/tools')
| -rw-r--r-- | src/tools/clangbackend/source/commandlinearguments.cpp | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/src/tools/clangbackend/source/commandlinearguments.cpp b/src/tools/clangbackend/source/commandlinearguments.cpp index cfc5052e8a..97c1982a58 100644 --- a/src/tools/clangbackend/source/commandlinearguments.cpp +++ b/src/tools/clangbackend/source/commandlinearguments.cpp @@ -32,9 +32,7 @@ #include <utils/qtcprocess.h> #include <QByteArray> -#include <QtCore/qdebug.h> - -#include <iostream> +#include <QDebug> static QList<QByteArray> splitArgs(QString &argsString) { @@ -121,11 +119,10 @@ static Utf8String maybeQuoted(const char *argumentAsCString) void CommandLineArguments::print() const { - using namespace std; + auto cerr = qCritical(); cerr << "Arguments to libclang:"; for (const auto &argument : m_arguments) - cerr << ' ' << maybeQuoted(argument).constData(); - cerr << endl; + cerr.noquote() << maybeQuoted(argument).constData(); } } // namespace ClangBackEnd |