diff options
| author | Nikolai Kosjar <nikolai.kosjar@qt.io> | 2018-02-02 15:18:40 +0100 |
|---|---|---|
| committer | Nikolai Kosjar <nikolai.kosjar@qt.io> | 2018-06-05 08:17:47 +0000 |
| commit | fdd695c35c271bd467fd9da8a67589d733443c67 (patch) | |
| tree | d2074d703864ecdccc8945686438cb0ccdb8c5c5 /src/tools/clangbackend/clangbackendmain.cpp | |
| parent | 89d6a36bc64b0e95136c925f4ed37f4520f9cb3a (diff) | |
| download | qt-creator-fdd695c35c271bd467fd9da8a67589d733443c67.tar.gz | |
Clang: Disable crash recovery in libclang
...because
1. We already run in a separate process.
2. It's not entirely clear in which state we end up after a crash,
except for:
3. A "crashed" translation unit won't be freed, even when calling
clang_disposeTranslationUnit().
This avoids undefined behavior within clangbackend and accumulated
leaking memory in the long run. On the other side, crashes within
libclang will crash clangbackend now, too.
Change-Id: I0789c52db08ace2f7e181e3b7bdfc9f595f75e8d
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Diffstat (limited to 'src/tools/clangbackend/clangbackendmain.cpp')
| -rw-r--r-- | src/tools/clangbackend/clangbackendmain.cpp | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/tools/clangbackend/clangbackendmain.cpp b/src/tools/clangbackend/clangbackendmain.cpp index 28b7f251b6..338fec7982 100644 --- a/src/tools/clangbackend/clangbackendmain.cpp +++ b/src/tools/clangbackend/clangbackendmain.cpp @@ -82,7 +82,6 @@ int main(int argc, char *argv[]) const QString connection = processArguments(application); - clang_toggleCrashRecovery(true); clang_enableStackTraces(); ClangCodeModelServer clangCodeModelServer; |