summaryrefslogtreecommitdiff
path: root/src/plugins
diff options
context:
space:
mode:
authorOrgad Shaneh <orgad.shaneh@audiocodes.com>2014-02-14 10:27:05 +0200
committerOrgad Shaneh <orgads@gmail.com>2014-02-14 10:38:34 +0100
commit48a5fb4b138940348dcb96637594167acba1117d (patch)
treee3f674fd299d6dd3bf8c47ef618f037318f73dc7 /src/plugins
parent5a562e9239998fd9a3980d34f6326efaab2d75a6 (diff)
downloadqt-creator-48a5fb4b138940348dcb96637594167acba1117d.tar.gz
PushToGerrit: Do not calculate number of commits for empty input
Change-Id: Ib2e5305dd47b486a963edf5bb04e6d16d76d5e68 Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
Diffstat (limited to 'src/plugins')
-rw-r--r--src/plugins/git/gerrit/gerritpushdialog.cpp5
1 files changed, 4 insertions, 1 deletions
diff --git a/src/plugins/git/gerrit/gerritpushdialog.cpp b/src/plugins/git/gerrit/gerritpushdialog.cpp
index 82a60cfed8..13a5eb9a4d 100644
--- a/src/plugins/git/gerrit/gerritpushdialog.cpp
+++ b/src/plugins/git/gerrit/gerritpushdialog.cpp
@@ -201,9 +201,12 @@ void GerritPushDialog::setChangeRange()
setRemoteBranches(true);
return;
}
+ const QString remoteBranchName = selectedRemoteBranchName();
+ if (remoteBranchName.isEmpty())
+ return;
QString remote = selectedRemoteName();
remote += QLatin1Char('/');
- remote += selectedRemoteBranchName();
+ remote += remoteBranchName;
const QString branch = m_ui->localBranchComboBox->currentText();
m_ui->infoLabel->setText(tr("Number of commits between %1 and %2: %3")
.arg(branch)