diff options
| author | Christian Kandeler <christian.kandeler@qt.io> | 2017-07-14 13:44:33 +0200 |
|---|---|---|
| committer | Christian Kandeler <christian.kandeler@qt.io> | 2017-07-17 07:51:23 +0000 |
| commit | be2b3c91ae4ddb97c35237da11b350c99cc6fd3b (patch) | |
| tree | 30e177b9f5a019b639966a13834c2d7fd2196594 /src/plugins/vcsbase | |
| parent | c9301e80bb960ba5df93fdd22932257542693154 (diff) | |
| download | qt-creator-be2b3c91ae4ddb97c35237da11b350c99cc6fd3b.tar.gz | |
Add Q_FALLTHROUGH for Qt < 5.8
... and make use of it.
With gcc 7, the new option -Wimplicit-fallthrough is introduced and
added to the -Wextra set, triggering dozens of warnings in our sources.
Therefore, we annotate all obviously intended fall-throughs. The ones
that are still left are unclear and need to be checked by the respective
maintainer.
Change-Id: I44ead33cd42a4b41c28ee5fcb5a31db272710bbc
Reviewed-by: Nikita Baryshnikov <nib952051@gmail.com>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Diffstat (limited to 'src/plugins/vcsbase')
| -rw-r--r-- | src/plugins/vcsbase/vcsbaseclientsettings.cpp | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/plugins/vcsbase/vcsbaseclientsettings.cpp b/src/plugins/vcsbase/vcsbaseclientsettings.cpp index 35c2a7c119..ab67910c2f 100644 --- a/src/plugins/vcsbase/vcsbaseclientsettings.cpp +++ b/src/plugins/vcsbase/vcsbaseclientsettings.cpp @@ -29,6 +29,7 @@ #include <utils/fileutils.h> #include <utils/hostosinfo.h> #include <utils/qtcassert.h> +#include <utils/qtcfallthrough.h> #include <QSettings> #include <QVariant> @@ -56,6 +57,7 @@ public: switch (v.type()) { case QVariant::UInt: m_type = QVariant::Int; + Q_FALLTHROUGH(); case QVariant::Int: m_comp.intValue = v.toInt(); break; |