VCSbase: Remove foreach / Q_FOREACH usage

Task-number: QTCREATORBUG-27464
Change-Id: I1088047513e7660907182e80303607d8c48919f5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>

1 files changed, 6 insertions, 4 deletions

diff --git a/src/plugins/vcsbase/wizard/vcscommandpage.cpp b/src/plugins/vcsbase/wizard/vcscommandpage.cpp
index f3297feceb..2cfc5b5d70 100644
--- a/src/plugins/vcsbase/wizard/vcscommandpage.cpp
+++ b/src/plugins/vcsbase/wizard/vcscommandpage.cpp
@@ -98,7 +98,8 @@ WizardPage *VcsCommandPageFactory::create(JsonWizard *wizard, Id typeId, const Q
                           tmp.value(QLatin1String(VCSCOMMAND_CHECKOUTNAME)).toString(),
                           args);
 
-    foreach (const QVariant &value, tmp.value(QLatin1String(VCSCOMMAND_JOBS)).toList()) {
+    const QVariantList values = tmp.value(QLatin1String(VCSCOMMAND_JOBS)).toList();
+    for (const QVariant &value : values) {
         const QVariantMap job = value.toMap();
         const bool skipEmpty = job.value(QLatin1String(JOB_SKIP_EMPTY), true).toBool();
         const FilePath workDir = FilePath::fromVariant(job.value(QLatin1String(JOB_WORK_DIRECTORY)));
@@ -183,7 +184,8 @@ bool VcsCommandPageFactory::validateData(Id typeId, const QVariant &data, QStrin
                     .arg(QLatin1String(VCSCOMMAND_JOBS));
         }
 
-        foreach (const QVariant &j, jobs.toList()) {
+        const QVariantList jobList = jobs.toList();
+        for (const QVariant &j : jobList) {
             if (j.isNull()) {
                 em = tr("Job in \"VcsCommand\" page is empty.");
                 break;
@@ -277,7 +279,7 @@ void VcsCommandPage::delayedInitialize()
         setStartedStatus(runMessage);
 
     QStringList extraArgs;
-    foreach (const QString &in, m_arguments) {
+    for (const QString &in : qAsConst(m_arguments)) {
         const QString tmp = wiz->expander()->expand(in);
         if (tmp.isEmpty())
            continue;
@@ -290,7 +292,7 @@ void VcsCommandPage::delayedInitialize()
             = vc->createInitialCheckoutCommand(repo, FilePath::fromString(base),
                                                name, extraArgs);
 
-    foreach (const JobData &job, m_additionalJobs) {
+    for (const JobData &job : qAsConst(m_additionalJobs)) {
         QTC_ASSERT(!job.job.isEmpty(), continue);
 
         if (!JsonWizard::boolFromVariant(job.condition, wiz->expander()))