diff options
| author | Christian Kandeler <christian.kandeler@qt.io> | 2020-04-09 17:47:01 +0200 |
|---|---|---|
| committer | Christian Kandeler <christian.kandeler@qt.io> | 2020-04-14 09:46:34 +0000 |
| commit | 0f163781888a6b3b39c705e5171db5ad0e766f6e (patch) | |
| tree | 91bfe182c2a929f04f04652fee954bbc315ea06f /src/plugins/vcsbase/vcsoutputformatter.h | |
| parent | deb0eaf7950e4aa4067af730367e61cbd732d178 (diff) | |
| download | qt-creator-0f163781888a6b3b39c705e5171db5ad0e766f6e.tar.gz | |
OutputFormatter: Do all formatting centrally
Instead of working directly on the text edit, the specialized
OutputFormatter classes now simply ask the base class to do it for them.
In practice, the request currently always is "turn this part of the text
into a link", but the interface can be extended to other types of
formatting, should that ever be required.
This is a win/win situation: Derived classes no longer have to fiddle
with QTextCursor & friends (nor do they have to call any base class
functions), while the base class can make strong assumptions about what
the derived class does to the text edit (i.e.: nothing).
Change-Id: Icc4bc52d4001b0359247563e39a206fa274833d7
Reviewed-by: hjk <hjk@qt.io>
Diffstat (limited to 'src/plugins/vcsbase/vcsoutputformatter.h')
| -rw-r--r-- | src/plugins/vcsbase/vcsoutputformatter.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/plugins/vcsbase/vcsoutputformatter.h b/src/plugins/vcsbase/vcsoutputformatter.h index 5074fc3392..32cc9de068 100644 --- a/src/plugins/vcsbase/vcsoutputformatter.h +++ b/src/plugins/vcsbase/vcsoutputformatter.h @@ -44,7 +44,7 @@ signals: void referenceClicked(const QString &reference); private: - Status handleMessage(const QString &text, Utils::OutputFormat format) override; + Result handleMessage(const QString &text, Utils::OutputFormat format) override; const QRegularExpression m_regexp; }; |