VcsBaseEditorWidget: Avoid using sender()

Change-Id: Id300535d40b52a2f7d3e69fca77ca75271da8711
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

1 files changed, 13 insertions, 13 deletions

diff --git a/src/plugins/vcsbase/vcsbaseeditor.cpp b/src/plugins/vcsbase/vcsbaseeditor.cpp
index 5e2c5f9ed5..21d46e99a5 100644
--- a/src/plugins/vcsbase/vcsbaseeditor.cpp
+++ b/src/plugins/vcsbase/vcsbaseeditor.cpp
@@ -360,8 +360,10 @@ QAction *ChangeTextCursorHandler::createAnnotateAction(const QString &change, bo
                 editorWidget()->annotatePreviousRevisionTextFormat() :
                 editorWidget()->annotateRevisionTextFormat();
     auto a = new QAction(format.arg(change), nullptr);
-    a->setData(change);
-    connect(a, &QAction::triggered, editorWidget(), &VcsBaseEditorWidget::slotAnnotateRevision);
+    VcsBaseEditorWidget *editor = editorWidget();
+    connect(a, &QAction::triggered, editor, [editor, change] {
+        editor->slotAnnotateRevision(change);
+    });
     return a;
 }
 
@@ -1493,18 +1495,16 @@ void VcsBaseEditorWidget::addDiffActions(QMenu *, const DiffChunk &)
 {
 }
 
-void VcsBaseEditorWidget::slotAnnotateRevision()
+void VcsBaseEditorWidget::slotAnnotateRevision(const QString &change)
 {
-    if (auto a = qobject_cast<const QAction *>(sender())) {
-        const int currentLine = textCursor().blockNumber() + 1;
-        const QString fileName = fileNameForLine(currentLine);
-        QString workingDirectory = d->m_workingDirectory;
-        if (workingDirectory.isEmpty())
-            workingDirectory = QFileInfo(fileName).absolutePath();
-        emit annotateRevisionRequested(FilePath::fromString(workingDirectory),
-                                       QDir(workingDirectory).relativeFilePath(fileName),
-                                       a->data().toString(), currentLine);
-    }
+    const int currentLine = textCursor().blockNumber() + 1;
+    const QString fileName = fileNameForLine(currentLine);
+    QString workingDirectory = d->m_workingDirectory;
+    if (workingDirectory.isEmpty())
+        workingDirectory = QFileInfo(fileName).absolutePath();
+    emit annotateRevisionRequested(FilePath::fromString(workingDirectory),
+                                   QDir(workingDirectory).relativeFilePath(fileName),
+                                   change, currentLine);
 }
 
 QStringList VcsBaseEditorWidget::annotationPreviousVersions(const QString &) const