Fix Krazy warnings about values or keys iteration in Editor/C++.

Change-Id: I46ff779bae6d7bba105bc2019228ba38b95dc352
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>

1 files changed, 5 insertions, 1 deletions

diff --git a/src/plugins/texteditor/snippets/snippetscollection.cpp b/src/plugins/texteditor/snippets/snippetscollection.cpp
index 92a3686b58..aebb2aaf64 100644
--- a/src/plugins/texteditor/snippets/snippetscollection.cpp
+++ b/src/plugins/texteditor/snippets/snippetscollection.cpp
@@ -319,11 +319,15 @@ bool SnippetsCollection::synchronize(QString *errorString)
     }
     Utils::FileSaver saver(m_userSnippetsPath + m_userSnippetsFile);
     if (!saver.hasError()) {
+        typedef QHash<QString, int>::ConstIterator GroupIndexByIdConstIt;
+
         QXmlStreamWriter writer(saver.file());
         writer.setAutoFormatting(true);
         writer.writeStartDocument();
         writer.writeStartElement(kSnippets);
-        foreach (const QString &groupId, m_groupIndexById.keys()) {
+        const GroupIndexByIdConstIt cend = m_groupIndexById.constEnd();
+        for (GroupIndexByIdConstIt it = m_groupIndexById.constBegin(); it != cend; ++it ) {
+            const QString &groupId = it.key();
             const int size = m_snippets.at(groupIndex(groupId)).size();
             for (int i = 0; i < size; ++i) {
                 const Snippet &current = snippet(i, groupId);