diff options
author | hjk <hjk@qt.io> | 2019-07-23 10:17:57 +0200 |
---|---|---|
committer | hjk <hjk@qt.io> | 2019-07-23 15:51:45 +0000 |
commit | 8b72e9216746c04e68a1c6498ac3396942fbebce (patch) | |
tree | c8742f1cf932ec3fae5a3f6476b390dbeb06ec9e /src/plugins/subversion | |
parent | 80716610c5f4deb32af15f1189363bf2ebffa41e (diff) | |
download | qt-creator-8b72e9216746c04e68a1c6498ac3396942fbebce.tar.gz |
Utils: Add CommandLine convenience constructors
... taking a QString for the executable.
This weakens the very explicit QString -> FileName conversion via the
named constructors for the special case of constructing a CommandLine.
I think that's worthwhile here, as it reduces the noise on the caller
site under circumstance where the nature of the thing is obvious.
Change-Id: I27b4a73639728893d053b2e7ba65cb745f0ffe83
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src/plugins/subversion')
-rw-r--r-- | src/plugins/subversion/subversionclient.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/plugins/subversion/subversionclient.cpp b/src/plugins/subversion/subversionclient.cpp index 4b6a9fbf1b..aa03bdb917 100644 --- a/src/plugins/subversion/subversionclient.cpp +++ b/src/plugins/subversion/subversionclient.cpp @@ -150,7 +150,7 @@ QString SubversionClient::synchronousTopic(const QString &repository) svnVersionBinary = svnVersionBinary.left(pos + 1); svnVersionBinary.append(HostOsInfo::withExecutableSuffix("svnversion")); const SynchronousProcessResponse result - = vcsFullySynchronousExec(repository, {FilePath::fromString(svnVersionBinary), args}); + = vcsFullySynchronousExec(repository, {svnVersionBinary, args}); if (result.result != SynchronousProcessResponse::Finished) return QString(); |