diff options
| author | hjk <hjk@qt.io> | 2019-07-23 10:58:00 +0200 |
|---|---|---|
| committer | hjk <hjk@qt.io> | 2019-07-23 11:55:59 +0000 |
| commit | 251287f0d35dd82e68dabed8214ef8af893aff91 (patch) | |
| tree | a3ba843c1c23f4aea06bc01bf7ab0dd69d6fc741 /src/plugins/qmlprofiler/tests | |
| parent | 2b26eca80f9ebcdc2f1dc0d890a39a4fbc2d129c (diff) | |
| download | qt-creator-251287f0d35dd82e68dabed8214ef8af893aff91.tar.gz | |
Avoid warning on empty expressions
For some reason, Q_UNUSED includes already a semicolon, adding one
on the user side creates an additional empty statement.
Change-Id: I9c5e8fac381345a60792cb75e2938fd53958d3b0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Diffstat (limited to 'src/plugins/qmlprofiler/tests')
| -rw-r--r-- | src/plugins/qmlprofiler/tests/qmlprofilerclientmanager_test.cpp | 4 | ||||
| -rw-r--r-- | src/plugins/qmlprofiler/tests/qmlprofilerdetailsrewriter_test.cpp | 10 |
2 files changed, 7 insertions, 7 deletions
diff --git a/src/plugins/qmlprofiler/tests/qmlprofilerclientmanager_test.cpp b/src/plugins/qmlprofiler/tests/qmlprofilerclientmanager_test.cpp index 70b815776b..a4f2cafaa9 100644 --- a/src/plugins/qmlprofiler/tests/qmlprofilerclientmanager_test.cpp +++ b/src/plugins/qmlprofiler/tests/qmlprofilerclientmanager_test.cpp @@ -123,7 +123,7 @@ void QmlProfilerClientManagerTest::testConnectionFailure() QByteArray fatalAsserts = qgetenv("QTC_FATAL_ASSERTS"); qunsetenv("QTC_FATAL_ASSERTS"); MessageHandler handler(&softAssertMessageHandler); - Q_UNUSED(handler); + Q_UNUSED(handler) QFETCH(QmlProfilerModelManager *, modelManager); QFETCH(QmlProfilerStateManager *, stateManager); @@ -342,7 +342,7 @@ void invalidHelloMessageHandler(QtMsgType type, const QMessageLogContext &contex void QmlProfilerClientManagerTest::testInvalidData() { MessageHandler handler(&invalidHelloMessageHandler); - Q_UNUSED(handler); + Q_UNUSED(handler) QSignalSpy openedSpy(&clientManager, SIGNAL(connectionOpened())); QSignalSpy closedSpy(&clientManager, SIGNAL(connectionClosed())); diff --git a/src/plugins/qmlprofiler/tests/qmlprofilerdetailsrewriter_test.cpp b/src/plugins/qmlprofiler/tests/qmlprofilerdetailsrewriter_test.cpp index 55787e918b..e189656a79 100644 --- a/src/plugins/qmlprofiler/tests/qmlprofilerdetailsrewriter_test.cpp +++ b/src/plugins/qmlprofiler/tests/qmlprofilerdetailsrewriter_test.cpp @@ -89,7 +89,7 @@ QmlProfilerDetailsRewriterTest::QmlProfilerDetailsRewriterTest(QObject *parent) void QmlProfilerDetailsRewriterTest::testMissingModelManager() { DummyBuildConfigurationFactory factory; - Q_UNUSED(factory); + Q_UNUSED(factory) seedRewriter(); delete m_modelManager; @@ -99,8 +99,8 @@ void QmlProfilerDetailsRewriterTest::testMissingModelManager() QVERIFY(!m_rewriterDone); auto rewriteConnection = connect(&m_rewriter, &QmlProfilerDetailsRewriter::rewriteDetailsString, this, [&](int typeId, const QString &string) { - Q_UNUSED(typeId); - Q_UNUSED(string); + Q_UNUSED(typeId) + Q_UNUSED(string) QFAIL("found nonexisting file in nonexisting model manager"); }); m_rewriter.requestDetailsForLocation(44, QmlEventLocation("Test.qml", 12, 12)); @@ -113,7 +113,7 @@ void QmlProfilerDetailsRewriterTest::testMissingModelManager() void QmlProfilerDetailsRewriterTest::testRequestDetailsForLocation() { DummyBuildConfigurationFactory factory; - Q_UNUSED(factory); + Q_UNUSED(factory) seedRewriter(); QVERIFY(!m_rewriterDone); @@ -164,7 +164,7 @@ void QmlProfilerDetailsRewriterTest::testRequestDetailsForLocation() void QmlProfilerDetailsRewriterTest::testGetLocalFile() { DummyBuildConfigurationFactory factory; - Q_UNUSED(factory); + Q_UNUSED(factory) seedRewriter(); QCOMPARE(m_rewriter.getLocalFile("notthere.qml"), QString()); |