diff options
| author | Tobias Hunger <tobias.hunger@theqtcompany.com> | 2015-09-02 17:11:30 +0200 |
|---|---|---|
| committer | Tobias Hunger <tobias.hunger@theqtcompany.com> | 2015-09-03 13:15:56 +0000 |
| commit | 396c0337074e2442dd467bd02a772b3b7689e079 (patch) | |
| tree | 5d4167143417360a973462d9c88f617c9b861c88 /src/plugins/projectexplorer/buildsettingspropertiespage.cpp | |
| parent | 2186d0815a0b3434b1c306796ac0587c12f9fe82 (diff) | |
| download | qt-creator-396c0337074e2442dd467bd02a772b3b7689e079.tar.gz | |
Project: Fix possible crash with projects without build configuration
Do not allow to rename buildconfigurations if there are none.
Change-Id: I3da2ea9568c2dabf555685c3b27192bea8dcc009
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
Diffstat (limited to 'src/plugins/projectexplorer/buildsettingspropertiespage.cpp')
| -rw-r--r-- | src/plugins/projectexplorer/buildsettingspropertiespage.cpp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/plugins/projectexplorer/buildsettingspropertiespage.cpp b/src/plugins/projectexplorer/buildsettingspropertiespage.cpp index a303b4210e..a801ac9e27 100644 --- a/src/plugins/projectexplorer/buildsettingspropertiespage.cpp +++ b/src/plugins/projectexplorer/buildsettingspropertiespage.cpp @@ -199,7 +199,9 @@ void BuildSettingsWidget::updateBuildSettings() clearWidgets(); // update buttons - m_removeButton->setEnabled(m_target->buildConfigurations().size() > 1); + QList<BuildConfiguration *> bcs = m_target->buildConfigurations(); + m_removeButton->setEnabled(bcs.size() > 1); + m_renameButton->setEnabled(!bcs.isEmpty()); if (!m_buildConfiguration) return; @@ -288,6 +290,7 @@ QString BuildSettingsWidget::uniqueName(const QString & name) void BuildSettingsWidget::renameConfiguration() { + QTC_ASSERT(m_buildConfiguration, return); bool ok; QString name = QInputDialog::getText(this, tr("Rename..."), tr("New name for build configuration <b>%1</b>:"). |