diff options
| author | Alessandro Portale <alessandro.portale@qt.io> | 2020-11-18 22:42:51 +0100 |
|---|---|---|
| committer | Alessandro Portale <alessandro.portale@qt.io> | 2020-11-19 08:42:14 +0000 |
| commit | b2a766a79ac778febff87f0def34cf6d3f4f93e3 (patch) | |
| tree | 8948acefd801721406f4e4015dde6616f4ee0303 /src/plugins/perfprofiler | |
| parent | 0c0347ce61a55b972178a8a07bb4f0c819555219 (diff) | |
| download | qt-creator-b2a766a79ac778febff87f0def34cf6d3f4f93e3.tar.gz | |
Don't access static functions/fields via instance
Courtesy of readability-static-accessed-through-instance
Change-Id: I71f54244f1e091315dac2943d9e1bfad6efa56a9
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Diffstat (limited to 'src/plugins/perfprofiler')
| -rw-r--r-- | src/plugins/perfprofiler/perfconfigwidget.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/plugins/perfprofiler/perfconfigwidget.cpp b/src/plugins/perfprofiler/perfconfigwidget.cpp index 6473d19d2e..273194de06 100644 --- a/src/plugins/perfprofiler/perfconfigwidget.cpp +++ b/src/plugins/perfprofiler/perfconfigwidget.cpp @@ -281,7 +281,7 @@ QWidget *SettingsDelegate::createEditor(QWidget *parent, const QStyleOptionViewI QComboBox *editor = new QComboBox(parent); for (int i = PerfConfigEventsModel::SubTypeEventTypeHardware; i < PerfConfigEventsModel::SubTypeEventTypeSoftware; ++i) { - editor->addItem(model->subTypeString(PerfConfigEventsModel::EventTypeHardware, + editor->addItem(PerfConfigEventsModel::subTypeString(PerfConfigEventsModel::EventTypeHardware, PerfConfigEventsModel::SubType(i)), i); } return editor; @@ -290,7 +290,7 @@ QWidget *SettingsDelegate::createEditor(QWidget *parent, const QStyleOptionViewI QComboBox *editor = new QComboBox(parent); for (int i = PerfConfigEventsModel::SubTypeEventTypeSoftware; i < PerfConfigEventsModel::SubTypeEventTypeCache; ++i) { - editor->addItem(model->subTypeString(PerfConfigEventsModel::EventTypeSoftware, + editor->addItem(PerfConfigEventsModel::subTypeString(PerfConfigEventsModel::EventTypeSoftware, PerfConfigEventsModel::SubType(i)), i); } return editor; @@ -299,7 +299,7 @@ QWidget *SettingsDelegate::createEditor(QWidget *parent, const QStyleOptionViewI QComboBox *editor = new QComboBox(parent); for (int i = PerfConfigEventsModel::SubTypeEventTypeCache; i < PerfConfigEventsModel::SubTypeInvalid; ++i) { - editor->addItem(model->subTypeString(PerfConfigEventsModel::EventTypeCache, + editor->addItem(PerfConfigEventsModel::subTypeString(PerfConfigEventsModel::EventTypeCache, PerfConfigEventsModel::SubType(i)), i); } return editor; |