diff options
| author | Alessandro Portale <alessandro.portale@qt.io> | 2020-11-21 01:04:56 +0100 |
|---|---|---|
| committer | Alessandro Portale <alessandro.portale@qt.io> | 2020-11-27 09:16:08 +0000 |
| commit | 81f3452e1cf8cc7788ace0e920a75cded52c0ae7 (patch) | |
| tree | 85db4b9a8d64544b7a8a15ec3911ee96e82b1e5d /src/plugins/modeleditor | |
| parent | 5951b26f1a67dd508a48788deb3a07b16220f4f3 (diff) | |
| download | qt-creator-81f3452e1cf8cc7788ace0e920a75cded52c0ae7.tar.gz | |
Aggregation/Utils/ExtensionSystem: Make member functions const/static
readability-make-member-function-const finds lots of member functions
that could be made const. This change just picks getter functions that
really should be const.
readability-convert-member-functions-to-static finds non-static member
functions which do not access this. This change turns most of them
into static ones, but leaves some non static to keep the class API
consistent.
readability-static-accessed-through-instance fixes the places where
the originally non-static, now static functions were called through
instance.
Change-Id: I8cf16c01f7988a7c9d073b5f8ede6a9706b94fb0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Diffstat (limited to 'src/plugins/modeleditor')
| -rw-r--r-- | src/plugins/modeleditor/editordiagramview.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/plugins/modeleditor/editordiagramview.cpp b/src/plugins/modeleditor/editordiagramview.cpp index c7c93db493..f2c074b25c 100644 --- a/src/plugins/modeleditor/editordiagramview.cpp +++ b/src/plugins/modeleditor/editordiagramview.cpp @@ -49,8 +49,9 @@ EditorDiagramView::EditorDiagramView(QWidget *parent) { auto droputils = new Utils::DropSupport( this, - [](QDropEvent *event, Utils::DropSupport *dropSupport) - -> bool { return dropSupport->isFileDrop(event) || dropSupport->isValueDrop(event); }); + [](QDropEvent *event, Utils::DropSupport *) + -> bool { return Utils::DropSupport::isFileDrop(event) + || Utils::DropSupport::isValueDrop(event); }); connect(droputils, &Utils::DropSupport::filesDropped, this, &EditorDiagramView::dropFiles); connect(droputils, &Utils::DropSupport::valuesDropped, |