Help: Replace annoying URL syncing by explicit Open in Edit Mode

Qt Creator was syncing the current page in Help mode to the page shown
in the side-by-side view in edit mode.
This doesn't really make sense because context is completely lost.
Instead provide the explicit option to open a help page in edit mode,
also from the external help window.

Fixes: QTCREATORBUG-19198
Change-Id: I00698bb431d5c116dd1e0e1cbdc5fbd7421ac267
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>

1 files changed, 4 insertions, 3 deletions

diff --git a/src/plugins/help/helpwidget.h b/src/plugins/help/helpwidget.h
index f104e90b8d..40cca45e3d 100644
--- a/src/plugins/help/helpwidget.h
+++ b/src/plugins/help/helpwidget.h
@@ -25,6 +25,7 @@
 
 #pragma once
 
+#include <coreplugin/helpmanager.h>
 #include <coreplugin/icontext.h>
 
 #include <QAbstractTableModel>
@@ -109,10 +110,9 @@ protected:
     void closeEvent(QCloseEvent *) override;
 
 signals:
-    void openHelpMode(const QUrl &url);
+    void requestShowHelpUrl(const QUrl &url, Core::HelpManager::HelpViewerLocation location);
     void closeButtonClicked();
     void aboutToClose();
-    void sourceChanged(const QUrl &url);
     void filterActivated(const QString &name);
     void currentIndexChanged(int index);
 
@@ -122,10 +122,11 @@ private:
     void updateBackMenu();
     void updateForwardMenu();
     void updateWindowTitle();
-    void helpModeButtonClicked();
+    void postRequestShowHelpUrl(Core::HelpManager::HelpViewerLocation location);
     void closeCurrentPage();
     void saveState() const;
     bool supportsPages() const;
+    void closeWindow();
 
     void goHome();
     void addBookmark();