diff options
| author | David Schulz <david.schulz@qt.io> | 2018-11-16 08:58:03 +0100 |
|---|---|---|
| committer | David Schulz <david.schulz@qt.io> | 2018-11-16 08:24:39 +0000 |
| commit | fc5caf3e0fff736acf1fc6c30e95b9b40089c03d (patch) | |
| tree | a873ccd18e45b00482cdf54fec54e06c9d316d97 /src/plugins/help/helpviewer.cpp | |
| parent | b5a76be357087a3af76c66f116ad91f05d51b6b2 (diff) | |
| download | qt-creator-fc5caf3e0fff736acf1fc6c30e95b9b40089c03d.tar.gz | |
Help: fix calling QDesktopServices::openUrl when opening about:blank
Workaround QTBUG-71833
Fixes: QTCREATORBUG-21515
Change-Id: Iffa363ab94a8f71d958b04932c9829887bb00dd7
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Diffstat (limited to 'src/plugins/help/helpviewer.cpp')
| -rw-r--r-- | src/plugins/help/helpviewer.cpp | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/plugins/help/helpviewer.cpp b/src/plugins/help/helpviewer.cpp index e2cac11fc9..f1a568e918 100644 --- a/src/plugins/help/helpviewer.cpp +++ b/src/plugins/help/helpviewer.cpp @@ -138,6 +138,10 @@ bool HelpViewer::launchWithExternalApp(const QUrl &url) const QUrl &resolvedUrl = helpEngine.findFile(url); if (!resolvedUrl.isValid()) return false; + // Workaround QTBUG-71833 + // QHelpEngineCore::findFile returns a valid url even though the file does not exist + if (resolvedUrl.scheme() == "about" && resolvedUrl.path() == "blank") + return false; const QString& path = resolvedUrl.path(); if (!canOpenPage(path)) { |